[WIP] #147 Database Rework #148
Conversation
…raction # Conflicts: # src/main/java/com/alpsbte/plotsystem/commands/CMD_Plots.java # src/main/java/com/alpsbte/plotsystem/core/menus/ReviewPlotMenu.java # src/main/java/com/alpsbte/plotsystem/core/system/Builder.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/utils/PlotUtils.java
# Conflicts: # src/main/java/com/alpsbte/plotsystem/commands/plot/CMD_Plot_Abandon.java # src/main/java/com/alpsbte/plotsystem/commands/plot/CMD_Plot_Submit.java # src/main/java/com/alpsbte/plotsystem/commands/plot/CMD_Plot_UndoSubmit.java # src/main/java/com/alpsbte/plotsystem/core/menus/companion/CityProjectMenu.java # src/main/java/com/alpsbte/plotsystem/core/menus/companion/CompanionMenu.java # src/main/java/com/alpsbte/plotsystem/core/menus/companion/CountryMenu.java # src/main/java/com/alpsbte/plotsystem/core/system/CityProject.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/Plot.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/generator/DefaultPlotGenerator.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/utils/PlotUtils.java
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive database rework for the PlotSystem, modernizing the data layer architecture and replacing the HolographicDisplays dependency. The changes focus on improving database design, introducing a new review system, and expanding localization support.
Key Changes:
- Complete database schema modernization with new providers and abstraction layer
- New review system with toggle criteria and enhanced rating mechanics
- Migration from HolographicDisplays to DecentHolograms dependency
- Expanded localization with new database-driven translations
Reviewed Changes
Copilot reviewed 147 out of 176 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| Multiple language files (zh_CN.yml, ru_RU.yml, etc.) | Updated localization with new database sections and improved review system strings |
| items.yml | Added new item configurations for enhanced UI components |
| config.yml | Database configuration updates and dependency changes |
| Java source files | Database provider implementations, review system refactor, and tutorial system improvements |
Files not reviewed (5)
- .idea/copyright/AlpsMIT.xml: Language not supported
- .idea/copyright/profiles_settings.xml: Language not supported
- .idea/encodings.xml: Language not supported
- .idea/scopes/Java.xml: Language not supported
- .idea/vcs.xml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -69,6 +69,7 @@ difficulty: | |||
| menu-title: | |||
| close: "关闭" | |||
| back: "返回" | |||
| continue: 'Continue' | |||
There was a problem hiding this comment.
[nitpick] The value 'Continue' should be translated to Chinese to match the rest of the file's localization approach.
| continue: 'Continue' | |
| continue: "继续" |
| @@ -68,6 +69,7 @@ difficulty: | |||
| menu-title: | |||
| close: "Закрыть" | |||
| back: "Назад" | |||
| continue: 'Continue' | |||
There was a problem hiding this comment.
[nitpick] The value 'Continue' should be translated to Russian to match the rest of the file's localization approach.
| continue: 'Continue' | |
| continue: "Продолжить" |
| @@ -68,6 +69,7 @@ difficulty: | |||
| menu-title: | |||
| close: "Fechar" | |||
| back: "Voltar" | |||
| continue: 'Continue' | |||
There was a problem hiding this comment.
[nitpick] The value 'Continue' should be translated to Portuguese to match the rest of the file's localization approach.
| continue: 'Continue' | |
| continue: "Continuar" |
| @@ -68,6 +69,7 @@ difficulty: | |||
| menu-title: | |||
| close: "닫기" | |||
| back: "뒤로가기" | |||
| continue: 'Continue' | |||
There was a problem hiding this comment.
[nitpick] The value 'Continue' should be translated to Korean to match the rest of the file's localization approach.
| continue: 'Continue' | |
| continue: "계속하기" |
| menu-title: | ||
| close: 'Fermer' | ||
| back: 'Retour' | ||
| continue: 'Continue' |
There was a problem hiding this comment.
[nitpick] The value 'Continue' should be translated to French to match the rest of the file's localization approach.
| continue: 'Continue' | |
| continue: 'Continuer' |
| no-feedback: "No feedback" | ||
| accuracy-points: "Accuracy points" | ||
| block-palette-points: "Block palette points" | ||
| toggle-points: "Toggle points" | ||
| total-points: "Total points" |
There was a problem hiding this comment.
[nitpick] These new review system strings should be translated to the corresponding languages in other language files for consistency.
|
|
||
| public LineCmdEventTask(Player player, Component assignmentMessage, String blockName, int blockId, Map<Vector, Vector> linePoints, BiTaskAction<Vector, Vector> lineCmdAction) { | ||
| super(player, "//line", new String[]{blockName, String.valueOf(blockId)}, assignmentMessage, linePoints.size(), true); | ||
| public LineCmdEventTask(Player player, Component assignmentMessage, @NotNull List<String> blocks, @NotNull Map<Vector, Vector> linePoints, BiTaskAction<Vector, Vector> lineCmdAction) { |
There was a problem hiding this comment.
The parameter type changed from individual block parameters to a List blocks, but the super constructor still expects array parameters. Verify that blocks.toArray(new String[0]) properly converts the list.
| private int getStartDigits(@NotNull String message) { | ||
| int i = 0; | ||
| StringBuilder digits = new StringBuilder("0"); | ||
| while (i < message.length()) { | ||
| if (Character.isDigit(message.charAt(i))) { | ||
| digits.append(message.charAt(i)); | ||
| } else if (i == 0) { | ||
| return -1; | ||
| } else { | ||
| break; | ||
| } | ||
| i++; | ||
| } | ||
| return Integer.parseInt(digits.toString()); | ||
| } |
There was a problem hiding this comment.
The StringBuilder is initialized with '0' which means all parsed numbers will have a leading zero, causing incorrect parsing. It should be initialized as new StringBuilder() instead.
|
com.alpsbte.plotsystem.utils.enums.Category is not used anymore and should be deleted |
…-abstraction # Conflicts: # pom.xml # src/main/java/com/alpsbte/plotsystem/PlotSystem.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/generator/PlotWorldGenerator.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/utils/PlotUtils.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/world/PlotWorld.java # src/main/java/com/alpsbte/plotsystem/utils/Utils.java # src/main/resources/plugin.yml
|
The message BUILDER COULD NOT BE CREATED!! is send on a regular basis. Without any more infos, this is a active regression & have to be fixed |
…tup_BuildTeam.java
…to update/1.21-data-abstraction
…onsistency and correctly use default item Before we sometimes set no item at all which is confusing. Signed-off-by: Zoriot <[email protected]>
…nfiguration Signed-off-by: Zoriot <[email protected]>
… already on a plot and not specifying an id
…to update/1.21-data-abstraction
Signed-off-by: Zoriot <[email protected]>
We used to set the items SetAsync where the source and other stuff weren't. Also improved the plot filtering. Mainly written by GitHub CoPilot.
… management Otherwise /p members doesn't work at all without id.
This is a PR for issue #147
Last things missing: