-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fall damage reduction for blocks #374
Merged
smartcmd
merged 7 commits into
AllayMC:feat/fall-damage-reduction
from
KoshakMineDEV:master
Sep 11, 2024
Merged
feat: fall damage reduction for blocks #374
smartcmd
merged 7 commits into
AllayMC:feat/fall-damage-reduction
from
KoshakMineDEV:master
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KoshakMineDEV
commented
Sep 4, 2024
- Added getFallDamageReductionFactor instead of canResetFallDistance()
- Added Hay Bale Block as example how it will work
- Reworked fall damage calculation
- Added getFallDamageReductionFactor instead of canResetFallDistance() - Added Hay Bale Block as example how it will work - Reworked fall damage calculation
smartcmd
reviewed
Sep 4, 2024
Allay-Server/src/main/java/org/allaymc/server/entity/component/event/CEntityFallEvent.java
Outdated
Show resolved
Hide resolved
Allay-Server/src/main/java/org/allaymc/server/entity/component/EntityBaseComponentImpl.java
Show resolved
Hide resolved
Allay-Server/src/main/java/org/allaymc/server/block/component/BlockBaseComponentImpl.java
Outdated
Show resolved
Hide resolved
smartcmd
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
And please test player falling on seabed, I think your code won't works |
I think you can also add a property called |
smartcmd
added a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: Koshak_Mine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.