-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #4484: (feat) Improve retry_decorator with blacklist exceptions #5333
Draft
openhands-agent
wants to merge
14
commits into
main
Choose a base branch
from
openhands-fix-issue-4484
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
reviewed
Nov 30, 2024
…acklist exceptions
enyst
reviewed
Nov 30, 2024
enyst
reviewed
Nov 30, 2024
enyst
reviewed
Nov 30, 2024
enyst
reviewed
Nov 30, 2024
enyst
reviewed
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #4484.
The issue has been successfully resolved through the implementation of an enhanced retry mechanism. The key changes made include:
exclude_exceptions
parameter to theretry_decorator
that allows specifying exceptions that should not be retried, even if they inherit from retryable exceptions_should_retry
function that checks both the retryable and excluded exception listsThe solution directly addresses the original problem from issue #4482 where certain exceptions (specifically Cloudflare-related ones) needed to be treated as non-retryable despite inheriting from
APIError
. The implementation is clean, well-tested, and maintains backward compatibility while adding the new functionality.This can be confirmed by:
A PR review message could note that this implementation provides a flexible solution for handling exception inheritance hierarchies in retry logic, with specific support for the Cloudflare use case that prompted the original issue.
Automatic fix generated by OpenHands 🙌
To run this PR locally, use the following command: