Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(123pan): add warning for mismatched file count when listing files #6814

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

seiuneko
Copy link
Contributor

Fixes an issue where using file_name order could result in incorrect file counts compared to response fields.

As shown in the image below, the actual number of files in the root directory is 3, but the API's response field indicates 4. In another directory, the actual file count is 933, yet the API has returned only 787 files.
2024-07-19_12-12

After switching to a different sorting method, everything works correctly. Therefore, I've only added a warning here.

Fixes an issue where using `file_name` order could result in incorrect file counts compared to response fields.
@xhofe xhofe merged commit 2d57529 into AlistGo:main Jul 20, 2024
3 checks passed
@xrgzs
Copy link
Contributor

xrgzs commented Jul 20, 2024

Can you provide a patch for drivers/123_Share?

@seiuneko
Copy link
Contributor Author

@xrgzs The drivers/123_Share does not require this patch since the API does not return the Total field.
图片

I reported this issue to 123pan a few days ago and am currently waiting for a fix.
Additionally, I just tested and found that drivers/123_Share returns an incomplete list of files when sorting by filename. Switching to sorting by creation time, it works correctly.

akang943578 pushed a commit to akang943578/alist that referenced this pull request Jul 23, 2024
…AlistGo#6814)

Fixes an issue where using `file_name` order could result in incorrect file counts compared to response fields.
ForSourceCodeAnalysis pushed a commit to ForSourceCodeAnalysis/alist that referenced this pull request Aug 4, 2024
…AlistGo#6814)

Fixes an issue where using `file_name` order could result in incorrect file counts compared to response fields.
Three-taile-dragon pushed a commit to loognsss/blist that referenced this pull request Sep 26, 2024
…AlistGo#6814)

Fixes an issue where using `file_name` order could result in incorrect file counts compared to response fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants