[OGUI-1664] add new custom error for failed depedency#2854
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new custom error for a "Failed Dependency" scenario, updates error response handling to return a specific HTTP status for this error, and removes verbose debug logging in the Kafka consumer.
- Adds FailedDependencyError class
- Updates updateAndSendExpressResponseFromNativeError to support the new error
- Adds mocha tests for the new error and removes unnecessary debug logs in KafkaMessagesConsumer
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Framework/Backend/test/errors/mocha-updateExpressResponseFromNativeError.test.js | Adds a test case to verify the new error's behavior in updating the response. |
| Framework/Backend/kafka/KafkaMessagesConsumer.js | Removes a debug log message to reduce log spam. |
| Framework/Backend/errors/updateAndSendExpressResponseFromNativeError.js | Includes a new case in the switch statement to handle the FailedDependencyError. |
| Framework/Backend/errors/FailedDependencyError.js | Introduces the custom error class for failed dependencies. |
Files not reviewed (2)
- Framework/package-lock.json: Language not supported
- Framework/package.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
PR which: