D2H: PV Contributors for efficiency purpose #7717
Open
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deependra170598
requested review from
alibuild,
vkucera,
fcolamar,
fgrosa,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
NicoleBastid,
hahassan7,
jpxrk and
apalasciano
as code owners
fgrosa
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Hi @deependra170598, thanks! I have a few comments (see below)
| @@ -179,8 +186,11 @@ struct HfTaskDstarToD0Pi { | |||
| auto collision = candDstar.collision_as<CollisionsWCent>(); | |||
| auto centrality = collision.centFT0M(); // 0-100% | |||
|
|
|||
| registry.fill(HIST("Efficiency/hPVContributorsEventsWCand"), collision.numContrib(), centrality); | |||
There was a problem hiding this comment.
This should be filled per collision, not per candidate (i.e. it has to be moved outside the candidate loop)
Also, remember to rename it as suggested below
| auto signDstar = candDstar.signSoftPi(); | ||
| if (signDstar > 0) { | ||
| registry.fill(HIST("Efficiency/hPVContributorsEventsWCandSignal"), collision.numContrib(), centrality, (invDstar - invD0)); |
There was a problem hiding this comment.
Same for this (you can check in the candidate loop if you have at least one and after the candidate loop you fill the histo)
| @@ -190,6 +200,7 @@ struct HfTaskDstarToD0Pi { | |||
| registry.fill(HIST("QA/hPtProng0D0"), candDstar.ptProng0()); | |||
| registry.fill(HIST("QA/hPtProng1D0"), candDstar.ptProng1()); | |||
| } else if (signDstar < 0) { | |||
| registry.fill(HIST("Efficiency/hPVContributorsEventsWCandSignal"), collision.numContrib(), centrality, (invAntiDstar - invD0Bar)); | |||
|
|
||
| // Checking PV contributors from Data as well MC rec | ||
| // registry.add("Efficiency/hPVContributorsAllEvents", "PV Contributors; PV Contributor; entries",{HistType::kTH1I,{{100,0,300}}}); | ||
| registry.add("Efficiency/hPVContributorsEventsWCand", "PV Contributors; PV Contributor; FT0M Centrality", {HistType::kTH2F, {{100, 0, 300}, {axisCentrality}}}, true); |
There was a problem hiding this comment.
You already have the one with candidates in the other histogram
Suggested change
| registry.add("Efficiency/hPVContributorsEventsWCand", "PV Contributors; PV Contributor; FT0M Centrality", {HistType::kTH2F, {{100, 0, 300}, {axisCentrality}}}, true); | |
| registry.add("Efficiency/hPVContributorsEventsAll", "PV Contributors; PV Contributor; FT0M Centrality", {HistType::kTH2F, {{100, 0, 300}, {axisCentrality}}}, true); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fgrosa !
In this PR, I added two new histograms for PV Contributors to calculate the MC weight factors to find efficiency.
Let me know if any changes need to be made. Thanks