[PWGHF] added new file for Xic correlation#16510
Open
singhra1994 wants to merge 16 commits into
Open
Conversation
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#16510
vkucera
requested changes
Jun 2, 2026
[PWGHF] Please consider the following formatting changes to AliceO2Group#16510
vkucera
reviewed
Jun 4, 2026
vkucera
reviewed
Jun 4, 2026
vkucera
reviewed
Jun 4, 2026
vkucera
reviewed
Jun 4, 2026
vkucera
reviewed
Jun 4, 2026
vkucera
reviewed
Jun 4, 2026
vkucera
reviewed
Jun 4, 2026
vkucera
reviewed
Jun 4, 2026
vkucera
reviewed
Jun 4, 2026
vkucera
reviewed
Jun 4, 2026
[PWGHF] Please consider the following formatting changes to AliceO2Group#16510
vkucera
reviewed
Jun 4, 2026
vkucera
reviewed
Jun 4, 2026
vkucera
requested changes
Jun 5, 2026
Collaborator
vkucera
left a comment
There was a problem hiding this comment.
Hi @singhra1994 , thanks for the fixes. Please see a few more suggestions.
| } | ||
| } | ||
|
|
||
| template <bool IsMcRec, int LambdaType, typename AssocType, typename McPart> |
Collaborator
There was a problem hiding this comment.
You have defined the V0LambdaType type. Use it and you don't need the casting to int.
Suggested change
| template <bool IsMcRec, int LambdaType, typename AssocType, typename McPart> | |
| template <bool IsMcRec, V0LambdaType LambdaType, typename AssocType, typename McPart> |
| std::array<float, 3> pVec2{assoc.px(), assoc.py(), assoc.pz()}; | ||
| std::array moms{pVec1, pVec2}; | ||
|
|
||
| if constexpr (LambdaType == static_cast<int>(V0LambdaType::Lambda)) { // Lambda |
Collaborator
There was a problem hiding this comment.
Suggested change
| if constexpr (LambdaType == static_cast<int>(V0LambdaType::Lambda)) { // Lambda | |
| if constexpr (LambdaType == V0LambdaType::Lambda) { // Lambda |
| entryCandHadronMlInfo(outMl[0], outMl[1]); | ||
| entryCandHadronRecoInfo(candMass, false); | ||
|
|
||
| if constexpr (LambdaType == 0) { // Regular track |
Collaborator
There was a problem hiding this comment.
Don't use magic numbers. Use a named value of the same type.
Suggested change
| if constexpr (LambdaType == 0) { // Regular track | |
| if constexpr (LambdaType == V0LambdaType::NotLambda) { // Regular track |
| } | ||
|
|
||
| template <bool IsMcRec, int LambdaType, typename AssocType, typename McPart> | ||
| void fillCorrelationTable(bool trkPidFill, AssocType const& assoc, float const& candPt, float const& candEta, float const& candPhi, |
Collaborator
There was a problem hiding this comment.
Pass small types by value.
Suggested change
| void fillCorrelationTable(bool trkPidFill, AssocType const& assoc, float const& candPt, float const& candEta, float const& candPhi, | |
| void fillCorrelationTable(bool trkPidFill, AssocType const& assoc, float const candPt, float const candEta, float const candPhi, |
| int signAssoc = 0; | ||
| auto pVec1 = RecoDecayPtEtaPhi::pVector(candPt, candEta, candPhi); | ||
| double massPart2 = -999.0; | ||
| std::array<float, 3> pVec2{assoc.px(), assoc.py(), assoc.pz()}; |
Collaborator
There was a problem hiding this comment.
Suggested change
| std::array<float, 3> pVec2{assoc.px(), assoc.py(), assoc.pz()}; | |
| std::array pVec2{assoc.px(), assoc.py(), assoc.pz()}; |
Comment on lines
+1360
to
+1361
| auto trackV0Pos = assocParticle.template posTrack_as<TrackType>(); | ||
| auto trackV0Neg = assocParticle.template negTrack_as<TrackType>(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| auto trackV0Pos = assocParticle.template posTrack_as<TrackType>(); | |
| auto trackV0Neg = assocParticle.template negTrack_as<TrackType>(); | |
| auto const& trackV0Pos = assocParticle.template posTrack_as<TrackType>(); | |
| auto const& trackV0Neg = assocParticle.template negTrack_as<TrackType>(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.