Skip to content

[PWGHF] added new file for Xic correlation#16510

Open
singhra1994 wants to merge 16 commits into
AliceO2Group:masterfrom
singhra1994:master
Open

[PWGHF] added new file for Xic correlation#16510
singhra1994 wants to merge 16 commits into
AliceO2Group:masterfrom
singhra1994:master

Conversation

@singhra1994
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#16510
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx
Comment thread PWGHF/HFC/TableProducer/CMakeLists.txt Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
@vkucera vkucera marked this pull request as draft June 2, 2026 16:54
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/Utils/utilsCorrelations.h Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx Outdated
Comment thread PWGHF/HFC/TableProducer/correlatorXicHadrons.cxx
@singhra1994 singhra1994 marked this pull request as ready for review June 4, 2026 16:42
Copy link
Copy Markdown
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @singhra1994 , thanks for the fixes. Please see a few more suggestions.

}
}

template <bool IsMcRec, int LambdaType, typename AssocType, typename McPart>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have defined the V0LambdaType type. Use it and you don't need the casting to int.

Suggested change
template <bool IsMcRec, int LambdaType, typename AssocType, typename McPart>
template <bool IsMcRec, V0LambdaType LambdaType, typename AssocType, typename McPart>

std::array<float, 3> pVec2{assoc.px(), assoc.py(), assoc.pz()};
std::array moms{pVec1, pVec2};

if constexpr (LambdaType == static_cast<int>(V0LambdaType::Lambda)) { // Lambda
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if constexpr (LambdaType == static_cast<int>(V0LambdaType::Lambda)) { // Lambda
if constexpr (LambdaType == V0LambdaType::Lambda) { // Lambda

entryCandHadronMlInfo(outMl[0], outMl[1]);
entryCandHadronRecoInfo(candMass, false);

if constexpr (LambdaType == 0) { // Regular track
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use magic numbers. Use a named value of the same type.

Suggested change
if constexpr (LambdaType == 0) { // Regular track
if constexpr (LambdaType == V0LambdaType::NotLambda) { // Regular track

}

template <bool IsMcRec, int LambdaType, typename AssocType, typename McPart>
void fillCorrelationTable(bool trkPidFill, AssocType const& assoc, float const& candPt, float const& candEta, float const& candPhi,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass small types by value.

Suggested change
void fillCorrelationTable(bool trkPidFill, AssocType const& assoc, float const& candPt, float const& candEta, float const& candPhi,
void fillCorrelationTable(bool trkPidFill, AssocType const& assoc, float const candPt, float const candEta, float const candPhi,

int signAssoc = 0;
auto pVec1 = RecoDecayPtEtaPhi::pVector(candPt, candEta, candPhi);
double massPart2 = -999.0;
std::array<float, 3> pVec2{assoc.px(), assoc.py(), assoc.pz()};
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::array<float, 3> pVec2{assoc.px(), assoc.py(), assoc.pz()};
std::array pVec2{assoc.px(), assoc.py(), assoc.pz()};

Comment on lines +1360 to +1361
auto trackV0Pos = assocParticle.template posTrack_as<TrackType>();
auto trackV0Neg = assocParticle.template negTrack_as<TrackType>();
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto trackV0Pos = assocParticle.template posTrack_as<TrackType>();
auto trackV0Neg = assocParticle.template negTrack_as<TrackType>();
auto const& trackV0Pos = assocParticle.template posTrack_as<TrackType>();
auto const& trackV0Neg = assocParticle.template negTrack_as<TrackType>();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants