Skip to content

[PWGLF,PWGMM] Add event selection on ITS layers #16451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gbencedi wants to merge 3 commits into
base: master
Choose a base branch
from
+14 −3
Open

[PWGLF,PWGMM] Add event selection on ITS layers #16451

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
378106d
Add event selection on ITS layers
gbencedi May 29, 2026
57aa415
fix build error
gbencedi May 29, 2026
6387d0a
fix linter error
gbencedi May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ using namespace o2::aod::rctsel;

auto static constexpr CminCharge = 3.f;
auto static constexpr CintZero = 0;
auto static constexpr CintOne = 1;
auto static constexpr CintTwo = 2;
auto static constexpr Czero = 0.f;
auto static constexpr Cninety = 90.f;
Comment on lines 92 to 96
Copy link
Copy Markdown
Collaborator

@vkucera vkucera May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just numbers named after their values. This is as meaningless as using the numbers directly. The purpose of avoiding magic numbers is to link the values to their meanings. This is just silencing the linter error without actually following the rationale behind the error.

Copy link
Copy Markdown
Collaborator Author

@gbencedi gbencedi May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I will pay attention to that in the next commit.

auto static constexpr ConeHeighty = 180.f;
Expand All @@ -98,7 +100,7 @@ auto static constexpr CmaxAccFT0A = 4.9f;
auto static constexpr CminAccFT0C = -3.3f;
auto static constexpr CmaxAccFT0C = -2.1f;

constexpr int CevtSel = 15;
constexpr int CevtSel = 16;
constexpr int CtrkSel = 7;
constexpr int CtrkTrkBestSel = 6;
constexpr int CambTrkType = 7;
Expand All @@ -120,6 +122,7 @@ enum class EvtSel {
evtNoCollInRofStrict,
evtNoCollInRofStandard,
evtNoHighMultCollInPrevRof,
evtGoodITSLayersAll,
evtBelowMinOccup,
evtAboveMaxOccup,
evtRCTFlagChecker,
Expand Down Expand Up @@ -428,6 +431,7 @@ struct DndetaMFTPbPb {
Configurable<bool> requireNoCollInRofStrict{"requireNoCollInRofStrict", true, "requireNoCollInRofStrict"};
Configurable<bool> requireNoCollInRofStandard{"requireNoCollInRofStandard", false, "requireNoCollInRofStandard"};
Configurable<bool> requireNoHighMultCollInPrevRof{"requireNoHighMultCollInPrevRof", false, "requireNoHighMultCollInPrevRof"};
Configurable<bool> requireGoodITSLayersAll{"requireGoodITSLayersAll", true, "requireGoodITSLayersAll"};
Configurable<bool> requireNoCollInTimeRangeStd{"requireNoCollInTimeRangeStd", false, "reject collisions corrupted by the cannibalism, with other collisions within +/- 10 microseconds"};
Configurable<bool> requireNoCollInTimeRangeNarrow{"requireNoCollInTimeRangeNarrow", false, "reject collisions corrupted by the cannibalism, with other collisions within +/- 10 microseconds"};
Configurable<uint> occupancyEstimator{"occupancyEstimator", 1, "Occupancy estimator: 1 = trackOccupancyInTimeRange, 2 = ft0cOccupancyInTimeRange"};
Expand Down Expand Up @@ -577,6 +581,7 @@ struct DndetaMFTPbPb {
labelEvtSel[static_cast<int>(EvtSel::evtNoCollInRofStrict)] = "kNoCollInRofStrict";
labelEvtSel[static_cast<int>(EvtSel::evtNoCollInRofStandard)] = "kNoCollInRofStandard";
labelEvtSel[static_cast<int>(EvtSel::evtNoHighMultCollInPrevRof)] = "kNoHighMultCollInPrevRof";
labelEvtSel[static_cast<int>(EvtSel::evtGoodITSLayersAll)] = "kIsGoodITSLayersAll";
labelEvtSel[static_cast<int>(EvtSel::evtBelowMinOccup)] = "Below min occup.";
labelEvtSel[static_cast<int>(EvtSel::evtAboveMaxOccup)] = "Above max occup.";
labelEvtSel[static_cast<int>(EvtSel::evtRCTFlagChecker)] = "RCT Flag Checker";
Expand Down Expand Up @@ -2241,6 +2246,12 @@ struct DndetaMFTPbPb {
if constexpr (fillHis) {
registry.fill(HIST("Events/hEvtSel"), static_cast<int>(EvtSel::evtNoHighMultCollInPrevRof));
}
if (eventCuts.requireGoodITSLayersAll && !collision.selection_bit(o2::aod::evsel::kIsGoodITSLayersAll)) {
return false;
}
if constexpr (fillHis) {
registry.fill(HIST("Events/hEvtSel"), static_cast<int>(EvtSel::evtGoodITSLayersAll));
}
if (eventCuts.minOccupancy >= 0 &&
getOccupancy(collision, eventCuts.occupancyEstimator) <
eventCuts.minOccupancy) {
Expand Down Expand Up @@ -4960,9 +4971,9 @@ struct DndetaMFTPbPb {

if (gConf.cfgDCAtype == 0) {
dcaInfo[0] = dcaInfOrig[0];
} else if (gConf.cfgDCAtype == 1) {
} else if (gConf.cfgDCAtype == CintOne) {
dcaInfo[0] = dcaInfOrig[1];
} else if (gConf.cfgDCAtype == 2) {
} else if (gConf.cfgDCAtype == CintTwo) {
dcaInfo[0] = std::sqrt(dcaInfOrig[0] * dcaInfOrig[0] + dcaInfOrig[1] * dcaInfOrig[1]);
}
dcaInfo[1] = dcaInfOrig[2];
Expand Down
Loading