[PWGUD] Update FwdMuonsUPC by ariffero · Pull Request #16307 · AliceO2Group/O2Physics

ariffero · 2026-05-19T14:58:05Z

Change V0A veto: veto only sel BC
Remove histos and related configs
Add checks on two-trakcs cand in FwdMuonsUPC
Clean up of the task

github-actions · 2026-05-19T14:58:34Z

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#16307

rolavick

Hi Andrea,
please, see this PR #15390 it seems you are reverting its changes. (usage of "" and <> in includes)
Also, please change the name of the file in a way that it does not start with a capital letter, so FwdMuonsUPC.cxx -> fwdMuonsUPC.cxx
Roman

Change "" to <> in include statements

ariffero · 2026-05-21T14:34:13Z

Hi Andrea, please, see this PR #15390 it seems you are reverting its changes. (usage of "" and <> in includes) Also, please change the name of the file in a way that it does not start with a capital letter, so FwdMuonsUPC.cxx -> fwdMuonsUPC.cxx Roman

Hi Roman, thanks for spotting that, I did not notice it before. Now it should be ok.
Cheers,
Andrea

Please consider the following formatting changes to AliceO2Group#16307

rolavick · 2026-05-21T14:47:28Z

 /// \author Andrea Giovanni Riffero <andrea.giovanni.riffero@cern.ch>

-#include "PWGUD/DataModel/UDTables.h"
+#include <PWGUD/DataModel/UDTables.h>


This should stay under "", not <>

I put it under "", but then alibuild proposed a PR to change it to <>. What should I do?

@vkucera could you please suggest the O2 prefered way?

There is no such proposal in that PR.

@rolavick Can you be more specific?

@vkucera what is the preffered variant, #include <PWGUD/DataModel/UDTables.h> or #include "PWGUD/DataModel/UDTables.h"

#include "PWGUD/DataModel/UDTables.h" of course. The rule is simple and explained here https://aliceo2group.github.io/analysis-framework/docs/tools/#fixing-include-format.

rolavick · 2026-05-21T14:48:07Z

-#include "PWGUD/DataModel/UDTables.h"
+#include <PWGUD/DataModel/UDTables.h>

-#include <CommonConstants/MathConstants.h>


Why you delete MathConstants.h include, it is used for PI definition on L196 no?

Warnings on: PDG codes, header brackets and header included

vkucera · 2026-05-22T09:45:31Z

Hi Andrea, please, see this PR #15390 it seems you are reverting its changes. (usage of "" and <> in includes) Also, please change the name of the file in a way that it does not start with a capital letter, so FwdMuonsUPC.cxx -> fwdMuonsUPC.cxx Roman

Hi Roman, thanks for spotting that, I did not notice it before. Now it should be ok. Cheers, Andrea

Hi Andrea, it does not seem OK to me. You are still removing a lot of includes without apparent corresponding code changes.

vkucera · 2026-05-22T09:47:22Z

-  HistogramRegistry mcRecoRegistry{"mcRecoRegistry", {}, OutputObjHandlingPolicy::AnalysisObject, true, true};

  // CONFIGURABLES
  static constexpr double Pi = o2::constants::math::PI;


Please do not duplicate existing constants.

Suggested change

static constexpr double Pi = o2::constants::math::PI;

vkucera · 2026-05-22T09:48:06Z

  Configurable<int> nBinsRapidity{"nBinsRapidity", 250, "N bins in rapidity histo"};
  Configurable<float> lowRapidity{"lowRapidity", -4.5, "lower limit in rapidity histo"};
  Configurable<float> highRapidity{"highRapidity", -2., "upper limit in rapidity histo"};


There is ConfigurableAxis for this.

vkucera · 2026-05-22T09:49:57Z

tracks is not modified and should be passed by const&.

vkucera · 2026-05-22T09:50:15Z

vkucera · 2026-05-22T09:50:53Z

      if (candId < 0) {
        continue;
      }
+      if (std::abs(tr.pdgCode()) != pdg->GetParticle("mu-")->PdgCode()) {


Which PDG code do you want here?

vkucera · 2026-05-22T09:51:18Z

Members are not initialised.

vkucera · 2026-05-22T09:52:28Z

-    TLorentzVector p;
-    auto mMu = particleMass(kMuonPDG);
-    p.SetXYZM(fwdTrack.px(), fwdTrack.py(), fwdTrack.pz(), mMu);
+    ROOT::Math::PxPyPzMVector p{fwdTrack.px(), fwdTrack.py(), fwdTrack.pz(), o2::constants::physics::MassMuon};


Why do you need a 4-vector?

vkucera · 2026-05-22T09:57:42Z

@@ -514,9 +384,9 @@ struct FwdMuonsUPC {
    }


This seems overcomplicated. Don't you just want to pick randomly -1 or 1?

Please consider the following formatting changes to AliceO2Group#16307

Use pDCA and max amplitude of V0A as configurables instead of hard coded values.

For gen events that pass the reco, the calculation of the momentum of the pair had a typo.

Add check on number of tracks per candidates in the reco MC workflow. Add a return if gen tracks are not muons Remove misleading check on zdc time Remove commented out code and old comments

Re-implmenting commit 14410d7, that was cancelled by commit 189d423

ariffero added 3 commits May 14, 2026 16:41

Change V0A veto: veto only sel BC

14410d7

Remove histos and add checks on two-trakcs cand in FwdMuonsUPC

189d423

Merge branch 'AliceO2Group:master' into dev-mytask

6a40261

github-actions Bot added the pwgud label May 19, 2026

Please consider the following formatting changes

7a5ff14

alibuild mentioned this pull request May 19, 2026

Please consider the following formatting changes to #16307 ariffero/O2Physics#20

Merged

ariffero added 3 commits May 19, 2026 17:30

Merge pull request #20 from alibuild/alibot-cleanup-16307

42f72b8

Please consider the following formatting changes to AliceO2Group#16307

Merge branch 'AliceO2Group:master' into dev-mytask

e69f0bb

Merge branch 'AliceO2Group:master' into dev-mytask

e42faca

alibuild mentioned this pull request May 21, 2026

Please consider the following formatting changes to #16307 ariffero/O2Physics#21

Closed

Fix o2linter warnings on TLorenzVector

ac96e41

ariffero force-pushed the dev-mytask branch from dab26fc to ac96e41 Compare May 21, 2026 13:06

Fix o2 linter warnings on pgd

d99a3ed

alibuild mentioned this pull request May 21, 2026

Please consider the following formatting changes to #16307 ariffero/O2Physics#22

Merged

ariffero and others added 5 commits May 21, 2026 15:38

Fix o2linter warnings on non-const iterators

9f32210

Fix o2linter warnings on magic numbers

099afbb

Fix o2linter warnings

34518f6

Please consider the following formatting changes

3185b13

Merge pull request #22 from alibuild/alibot-cleanup-16307

86b2d68

Please consider the following formatting changes to AliceO2Group#16307

ariffero marked this pull request as ready for review May 21, 2026 14:06

ariffero requested review from alibuild, amatyja and rolavick as code owners May 21, 2026 14:06

rolavick requested changes May 21, 2026

View reviewed changes

ariffero and others added 3 commits May 21, 2026 16:24

Do not revert PR AliceO2Group#15390

2e790ad

Change "" to <> in include statements

Rename FwdMuonsUPC.cxx in fwdMuonsUPC.cxx

85168d2

Please consider the following formatting changes

8a14a74

alibuild mentioned this pull request May 21, 2026

Please consider the following formatting changes to #16307 ariffero/O2Physics#23

Merged

Merge pull request #23 from alibuild/alibot-cleanup-16307

490b909

Please consider the following formatting changes to AliceO2Group#16307

rolavick requested changes May 21, 2026

View reviewed changes

Fix warnings

90571b9

Warnings on: PDG codes, header brackets and header included

alibuild mentioned this pull request May 22, 2026

Please consider the following formatting changes to #16307 ariffero/O2Physics#24

Merged

vkucera reviewed May 22, 2026

View reviewed changes

Comment thread PWGUD/Tasks/fwdMuonsUPC.cxx Outdated

Copy link
Copy Markdown

Collaborator

vkucera May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tracks is not modified and should be passed by const&.

vkucera reviewed May 22, 2026

View reviewed changes

Comment thread PWGUD/Tasks/fwdMuonsUPC.cxx Outdated

Copy link
Copy Markdown

Collaborator

vkucera May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

vkucera reviewed May 22, 2026

View reviewed changes

Comment thread PWGUD/Tasks/fwdMuonsUPC.cxx Outdated

Comment on lines 307 to 312

Copy link
Copy Markdown

Collaborator

vkucera May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Members are not initialised.

vkucera reviewed May 22, 2026

View reviewed changes

vkucera marked this pull request as draft May 23, 2026 21:44

ariffero and others added 15 commits May 27, 2026 17:27

Delete unused constants

4c42ead

Add deleted includes

182e0fc

Use ConfigurableAxis

004755d

Initialize struct members

bdf170f

Pass non-modified iterators by const&

c5a2390

Back to PDG_t for PDG codes

f1323ef

Use RecoDecay methods instead of 4-vectors in isMuonSelected

5abe424

Please consider the following formatting changes

79c5938

Merge pull request #24 from alibuild/alibot-cleanup-16307

4ec3423

Please consider the following formatting changes to AliceO2Group#16307

Solve o2linter warning on executable name

1b23fd8

Add more configurables

dcbe034

Use pDCA and max amplitude of V0A as configurables instead of hard coded values.

Fix bug in momentum calculation

ad365b0

For gen events that pass the reco, the calculation of the momentum of the pair had a typo.

Fix small issues

26d4a4e

Add check on number of tracks per candidates in the reco MC workflow. Add a return if gen tracks are not muons Remove misleading check on zdc time Remove commented out code and old comments

Change V0A veto: veto only sel BC

e9d9c68

Re-implmenting commit 14410d7, that was cancelled by commit 189d423

Merge branch 'AliceO2Group:master' into dev-mytask

52c2dcf

ariffero marked this pull request as ready for review May 29, 2026 12:55

Conversation

ariffero commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rolavick left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ariffero commented May 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ariffero May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rolavick May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vkucera commented May 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented May 19, 2026 •

edited

Loading

rolavick left a comment •

edited

Loading

ariffero May 22, 2026 •

edited

Loading

rolavick May 21, 2026 •

edited

Loading