coreDataGrab shouldn't analyze elements' siblings #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreDataGrab exists to find the ad ID and token pertaining to an element by recursively iterating through its keys -- and those of any elements/arrays/objects that are values -- to find anything that seems like an ad ID or client token. Previously, this would analyze the `return` key which is something like the parent element. This meant that it would traverse up the tree and back down to siblings, which led to mistakes.
Codecov Report
@@ Coverage Diff @@
## develop #23 +/- ##
========================================
Coverage 97.10% 97.10%
========================================
Files 223 223
Lines 1554 1554
========================================
Hits 1509 1509
Misses 45 45 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coreDataGrab exists to find the ad ID and token pertaining to an element by
recursively iterating through its keys -- and those of any
elements/arrays/objects that are values -- to find anything that seems like
an ad ID or client token. Previously, this would analyze the
returnkeywhich is something like the parent element. This meant that it would traverse
up the tree and back down to siblings, which led to mistakes and unexpected behavior.