Skip to content

Allow rtsp params (like #backchannel=0) from onvif sources #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FIGIO55 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

Allow rtsp params (like #backchannel=0) from onvif sources #1959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/onvif/onvif.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"net/url"
"os"
"strconv"
"strings"
"time"

"github.com/AlexxIT/go2rtc/internal/api"
Expand All @@ -33,6 +34,9 @@ func Init() {
var log zerolog.Logger

func streamOnvif(rawURL string) (core.Producer, error) {
// Split the ONVIF URL to extract hash-based arguments
rawURL, rawQuery, _ := strings.Cut(rawURL, "#")

client, err := onvif.NewClient(rawURL)
if err != nil {
return nil, err
Expand All @@ -43,6 +47,11 @@ func streamOnvif(rawURL string) (core.Producer, error) {
return nil, err
}

// Append hash-based arguments to the retrieved URI
if rawQuery != "" {
uri = uri + "#" + rawQuery
}

log.Debug().Msgf("[onvif] new uri=%s", uri)

if err = streams.Validate(uri); err != nil {
Expand Down