Fix connection issues in conjunction with doorbird backchannel #1895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- proper session handling - honor http status codes - prevent device from being flooded by limiting concurrent audio channels
cleanup files
…backchannel audio streams are connected
remove orphaned streams
Code refactoring for AlexxIT#1895
AlexxIT
approved these changes
Oct 5, 2025
Owner
|
Thanks! |
Contributor
Author
|
Sometimes it happens, that backchannel connection where not closed eniterly. After thant, no new backchannel connections where established. {
"producers": [
{
"url": "rtsp://127.0.0.1:8554/spa01_video?video=all"
},
{
"url": "doorbird:/xxx@xxx?media=audio"
},
{
"id": 83159,
"format_name": "doorbird",
"protocol": "http",
"url": "doorbird://xxx@xxx",
"medias": [
"audio, sendonly, PCMU/8000"
],
"senders": [
{
"id": 83160,
"codec": {
"codec_name": "pcm_mulaw",
"codec_type": "audio",
"sample_rate": 8000
},
"parent": 33058
},
{
"id": 83161,
"codec": {
"codec_name": "pcm_mulaw",
"codec_type": "audio",
"sample_rate": 8000
},
"parent": 33073
},
{
"id": 83162,
"codec": {
"codec_name": "pcm_mulaw",
"codec_type": "audio",
"sample_rate": 8000
},
"parent": 80350
}
]
}
],
"consumers": []
}
|
Owner
|
This is definitely a bug. I don't know how to replicate it, so it's difficult to fix. Doorbird nested from go2rtc/pkg/doorbird/backchannel.go Lines 13 to 16 in cca216a This struct has Lines 77 to 79 in cca216a Probably in some cases this Stop is not called. You can also call GET |
Contributor
Author
|
Hi @AlexxIT, Here's the /api/stack output: I think this could work to avoid this behaviour: What do you think? UPDATE: |
Owner
|
Singleton for source is a very bad idea. Your code support only one camera per go2rtc. I think the problem might have been in your version too. It's just that the connections weren't multiplying. I think this is a global issue with go2rtc, not related to doorbird. It's that sometimes the backchannel doesn't close. It needs to figure out how to reliably reproduce this. |
|
It looks like, that I have the same Problem with my Doorbird connected to Frigate with the latest Version of go2RTC. At this moment, the Ringtone sounds bad. He sounds choppy. And he does not notify my FritzBox about the Keypress. If I use the Camera in Frigate without 1-Way or 2-Way Audio, Everything is working well. @oeiber Do you have solved the Problem? How did you have configured your Doorbell in go2rtc for 2-Way Audio? |
Contributor
Author
Hi, |
|
Hi and thanks for adding Documentation, but Problem still exists. |
Contributor
Author
Thats indeed a strange behaviour. Which model do you use? Does the problem also persist without the usage of frigate? In my setup I'm using go2rtc standalone in conjunction with homeassistant. My doorbird uses a webhook for motion and doorbell events. A HA automations starts recording a clip after a webhook was triggered. I can also see frame errors in my recordings after my doorbell initiates a sip call to my fritzbox. For my opinion this is related to the weak cpu inside my doorbird device. |
|
Hi, i am using a d1100. The problem also exists, after disabling the connection to the fritzbox. |
|
I am writing with Doorbird's technical support. The last Answeer: German: Translated in English: To still achieve audio recording, you would need to use clever timing so that, for example, Frigate does not occupy the audio channel for about 3 minutes after a doorbell ring at the DoorBird. The doorbell signal could be transmitted via an HTTP request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.