Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scAdvanced updates: dir_create and plotting #800

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

sjspielman
Copy link
Member

Closes #692
Closes #734

This PR updates scAdvanced notebooks by:

  • using fs::dir_create instead of dir.create
  • all colour -> color, and use brewer dark2 where we can
  • in the integration notebook, I also made the ggplot calls a bit more consistent with a more similar line order

@sjspielman sjspielman changed the title Sjspielman/692 734 scadvanced updates scAdvanced updates: dir_create and plotting Nov 4, 2024
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjspielman sjspielman merged commit b5d6474 into master Nov 5, 2024
2 checks passed
@sjspielman sjspielman deleted the sjspielman/692-734-scadvanced-updates branch November 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plotReducedDim and friends for scAdvanced Use fs::dir_create() in scAdvanced notebooks
2 participants