-
Notifications
You must be signed in to change notification settings - Fork 26
Add context for Vardict number of calls and more on sample seq prep #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
library prep text looks good, just had a Q about the 1.2M number origin
content/06.methods.md
Outdated
@@ -125,7 +126,7 @@ This workflow is available in the [D3b GitHub repository](https://github.com/d3b | |||
##### SNV and indel calling | |||
|
|||
For PBTA samples, we used four variant callers to call SNVs and indels from panel, WXS, and WGS data: `Strelka2` [@doi:10.1038/s41592-018-0051-x], `Mutect2` [@biorxiv:10.1101/861054], `Lancet` [@doi:10.1038/s42003-018-0023-9], and `VarDictJava` [@doi:10.1093/nar/gkw227]. | |||
`VarDictJava`-only calls were not retained since ~ 39M calls with low VAF were uniquely called and may be potential false positives. | |||
`VarDictJava`-only calls were not retained since ~ 39M calls with low VAF were uniquely called and may be potential false positives (~1.2M calls were included in consensus SNV calling described below). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this number in a notebook you can point me to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you read in the consensus MAF, this is the number of rows. It is also what is stated in the module README.
AppVeyor build 1.0.1048 for commit af96ea1 is now complete. Found 0 potential spelling error(s). Preview:... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving for once the updated change is made
AppVeyor build 1.0.1053 for commit 645eac2 is now complete. Found 0 potential spelling error(s). Preview:... |
[ci skip] This build is based on 6099cc0. This commit was created by the following CI build and job: https://github.com/AlexsLemonade/OpenPBTA-manuscript/commit/6099cc0ebb05c033058a2d2eabbf43bbcc285437/checks https://github.com/AlexsLemonade/OpenPBTA-manuscript/actions/runs/2967307497
[ci skip] This build is based on 6099cc0. This commit was created by the following CI build and job: https://github.com/AlexsLemonade/OpenPBTA-manuscript/commit/6099cc0ebb05c033058a2d2eabbf43bbcc285437/checks https://github.com/AlexsLemonade/OpenPBTA-manuscript/actions/runs/2967307497
Here I'm adding the following to the methods section: