Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Add context for Vardict number of calls and more on sample seq prep #345

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

jaclyn-taroni
Copy link
Member

Here I'm adding the following to the methods section:

  • Some context for how many calls Vardict uniquely made by stating how many calls made it into the consensus SNV data per a comment from @cansavvy received via email:

In the SNV section: "~ 39M calls with low VAF were uniquely called and may be potential false positives” Should ~39 million be put in perspective in some way? i.e. Out of how many calls that were not unique to 39 million? Or how many unique calls did the other callers have? It’s been enough time that I don’t even remember how 39 million compared to the other caller’s sets except that I remember it was a lot.

@jaclyn-taroni jaclyn-taroni requested a review from jharenza August 31, 2022 18:52
@jaclyn-taroni jaclyn-taroni marked this pull request as ready for review August 31, 2022 18:52
Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library prep text looks good, just had a Q about the 1.2M number origin

@@ -125,7 +126,7 @@ This workflow is available in the [D3b GitHub repository](https://github.com/d3b
##### SNV and indel calling

For PBTA samples, we used four variant callers to call SNVs and indels from panel, WXS, and WGS data: `Strelka2` [@doi:10.1038/s41592-018-0051-x], `Mutect2` [@biorxiv:10.1101/861054], `Lancet` [@doi:10.1038/s42003-018-0023-9], and `VarDictJava` [@doi:10.1093/nar/gkw227].
`VarDictJava`-only calls were not retained since ~ 39M calls with low VAF were uniquely called and may be potential false positives.
`VarDictJava`-only calls were not retained since ~ 39M calls with low VAF were uniquely called and may be potential false positives (~1.2M calls were included in consensus SNV calling described below).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this number in a notebook you can point me to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you read in the consensus MAF, this is the number of rows. It is also what is stated in the module README.

@AppVeyorBot
Copy link

AppVeyor build 1.0.1048 for commit af96ea1 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

@jharenza jharenza self-requested a review August 31, 2022 21:10
Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for once the updated change is made

@AppVeyorBot
Copy link

AppVeyor build 1.0.1053 for commit 645eac2 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants