fix(json): use local CharReaderBuilder for thread safety #4789
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Crash with:
Root Cause
The
JsonParserclass uses a sharedCharReaderBuildermember that gets accessed concurrently from multiple threads:getSocket1JsonReply()→parser_.parse()getSocket1JsonReply()→parser_.parse()Each module has its own mutex, but they all share the same
IPC::inst()singleton. The module mutexes don't protect the shared parser.Json::CharReaderBuilderis not thread-safe for concurrent use without synchronization.Fix
Use a local
CharReaderBuilderinparse()instead of a member variable. This makes each parse call independent and thread-safe.