Skip to content

Bug fix #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexGhiondea wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bug fix #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f454f58
Add references to the DotNet.ReproducibleBuilds packages
Jul 13, 2021
84690fb
By default, no label specified should be empty
Oct 1, 2021
26d2bc4
Support net5
Oct 1, 2021
6f83708
List labels in order
Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CmdLineArgs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ internal class CmdLineArgs
[ArgumentGroup(nameof(CommandAction.List))]
public GitHubObjectType ObjectType { get; set; }

[OptionalArgument(0, "label", "Specific label that you want to filter issues by. If not specified, all issues are returned")]
[OptionalArgument("", "label", "Specific label that you want to filter issues by. If not specified, all issues are returned")]
[ArgumentGroup(nameof(CommandAction.List))]
public string Label { get; set; }

Expand Down
2 changes: 1 addition & 1 deletion src/Creator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFrameworks>netcoreapp3.1;net5.0</TargetFrameworks>
<AssemblyName>GHCreator</AssemblyName>
</PropertyGroup>

Expand Down
8 changes: 6 additions & 2 deletions src/Models/Objects/Issue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using System.Text;

namespace Creator.Models.Objects
Expand All @@ -11,14 +12,17 @@ public class Issue : GitHubObject, IConvertToOctokit<Octokit.NewIssue>
{
public string AssignedTo { get; set; }
public string Milestone { get; set; }

public string RepositoryName { get; set; }
public string OrganizationName { get; set; }

public string Labels { get; set; }

public Issue(Octokit.Issue issue) : base(issue.Title, issue.HtmlUrl)
{
AssignedTo = issue.Assignee?.Login;
Milestone = issue.Milestone?.Title;
Labels = string.Join(",", issue.Labels.OrderBy(x => x.Name).Select(x => x.Name));
}

public Issue(params string[] entries) : base(entries)
Expand Down Expand Up @@ -57,7 +61,7 @@ public override int GetHashCode()

public override string ToString()
{
return $"Issue,{base.ToString()},{AssignedTo},{Milestone},{RepositoryName},{OrganizationName}";
return $"Issue,{base.ToString()},{AssignedTo},{Milestone},{RepositoryName},{OrganizationName},{Labels}";
}

public NewIssue ConvertTo()
Expand Down