Use math.min/max and increase volume limit #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ale32bit
requested changes
May 23, 2024
| @@ -9,7 +9,7 @@ DFPWM and MDFPWM audio player for ComputerCraft. | |||
| Quartz can be installed by executing the `download.lua` file or by copy pasting this command: | |||
|
|
|||
| ``` | |||
| wget run https://raw.github.com/Ale32bit/Quartz/main/download.lua | |||
| wget run https://raw.github.com/Ale32Bit/Quartz/main/download.lua | |||
| @@ -1,4 +1,4 @@ | |||
| local base = "https://raw.github.com/Ale32bit/Quartz/main/" | |||
| local base = "https://raw.githubusercontent.com/Bioscreeper/Quartz/main/" | |||
| if dist < 0 then | ||
| dist = 0 | ||
| end | ||
| dist = math.min(math.max(dist, 1), 3) |
There was a problem hiding this comment.
Set minimum to 0 instead of 1.
The second argument of speaker.playAudio accepts lower than 1 numbers.
There was a problem hiding this comment.
Should also update the relevant documentation to reflect the range change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.