Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checksum skip checkbox to settings window #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

animeavi
Copy link

@animeavi animeavi commented Nov 16, 2022

Fixes #49

image
image

subvod added a commit to subvod/FlipsCygwin that referenced this pull request Mar 24, 2023
subvod added a commit to subvod/FlipsCygwin that referenced this pull request Mar 24, 2023
@subvod
Copy link

subvod commented Mar 25, 2023

Thanks for this. Makes patching expansions a lot less painful.

@Miepee
Copy link
Contributor

Miepee commented May 30, 2024

@Alcaro is there anything specifically that's blocking this PR?

@Alcaro
Copy link
Owner

Alcaro commented May 30, 2024

As mentioned in #49, I'm not a huge fan of this approach, so I don't want to merge it. But it's properly written, and it adds a feature people ask for, so I don't want to reject it just because I'm a cranky lil shit.

That doesn't leave a whole lot of options.

@Miepee
Copy link
Contributor

Miepee commented May 30, 2024

If the point is to protect noobs from shooting themselves in the foot, the GUI label could be changed DANGEROUS: Ignore checksum when patching and/or pop up a dialog box asking the user if they really want to disable them and explain them briefly the consequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore checksum option for bps
4 participants