Add checksum skip checkbox to settings window #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animeavi
force-pushed
the
checksum_checkbox
branch
from
df3041d
to
afbdc4f
Compare
subvod
added a commit
to subvod/FlipsCygwin
that referenced
this pull request
Mar 24, 2023
subvod
added a commit
to subvod/FlipsCygwin
that referenced
this pull request
Mar 24, 2023
|
Thanks for this. Makes patching expansions a lot less painful. |
|
@Alcaro is there anything specifically that's blocking this PR? |
|
As mentioned in #49, I'm not a huge fan of this approach, so I don't want to merge it. But it's properly written, and it adds a feature people ask for, so I don't want to reject it just because I'm a cranky lil shit. That doesn't leave a whole lot of options. |
|
If the point is to protect noobs from shooting themselves in the foot, the GUI label could be changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49