Fix bug for no indels #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, I tried to sort this issue a while back but clearly didn't do a very thorough job. Thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running into a bug on datasets without indels. Specifically, in
check_on_ref_genome.R, there is a failure torbindtheindel_dtand thesumstat_dt. I have deduced that the issue is on my line 120 in this PR, where you are doingindel_dt[, IMPUTATION_SNP := NA]- this is adding a column toindel_dt, so that when you try torbindthe two DTs together, there is an error about the number of columns.In this fix, the line is not called if the user specifies no indels. that way, the
indel_dtstays as a 0-row, 0-column DT and can be successfullyrbind-ed.I also fixed an indentation mismatch that i came across in the same file.
Thanks!