bug fix: reporting genome-wide sign P

Al-Murphy · Jul 22, 2023 · 45259df · 45259df
1 parent 5ad4a42
commit 45259df
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: MungeSumstats
 Type: Package
 Title: Standardise summary statistics from GWAS
-Version: 1.9.13
+Version: 1.9.14
 Authors@R:
     c(person(given = "Alan",
            family = "Murphy",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,8 @@
+## CHANGES IN VERSION 1.9.14
+
+### Bug fix
+* Fix reporting of genome-wide sign variants before formatting.
+
 ## CHANGES IN VERSION 1.9.13
 
 ### Bug fix

diff --git a/R/report_summary.R b/R/report_summary.R
@@ -34,6 +34,9 @@ report_summary <- function(sumstats_dt,
         NULL
     }
     P_msg <- if ("P" %in% colnames(sumstats_dt)) {
+        if (!is.numeric(sumstats_dt$P)){
+          sumstats_dt[,P:=as.numeric(P)]
+        }
         paste0("\n   - ", 
                formatC(nrow(subset(sumstats_dt, P < 5e-8)),
                        big.mark = ",", format = "fg"),