Add shuffle all option in home menu - closes #313 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucaxvi
commented
Oct 31, 2024
lucaxvi
commented
- Adds a "shuffle all" option to the three dot menu.
- Fixes a bug with the shuffle all button in the songs fragment skipping some songs.
|
Won't shuffle all now always start at the same song? |
|
It looks like exoplayer is smart enough to start the playlist with a random song when shuffle mode is enabled and you call setMediaItems without passing a start index. I just tested it and it works as intended. |
|
That code does predate the introduction of CircularShuffleOrder by a few months so I guess that makes sense. Give me some time in general to get back to Gramophone and I'll probably merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.