Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TypeScript type definitions #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liamjones
Copy link

@liamjones liamjones commented May 26, 2020

Also available via @types/react-native-global-props.

@myarete
Copy link

myarete commented May 31, 2020

Would love to have this merged :)

@fredericoamsb
Copy link

Merge this pls :)

@vimaire
Copy link

vimaire commented Sep 2, 2020

Hi, having done the work, how about you submit it to the https://github.com/DefinitelyTyped/DefinitelyTyped repository ?
this way, anyone will be able to install the type definitions

@nhbravo
Copy link

nhbravo commented Oct 20, 2020

It would be cool to see this merged 👍

@liamjones
Copy link
Author

Wow, did I really raise this back in May? Time flies in lockdown...

@vimaire Good idea, I'll see if I can find time to do this soon.

@SHRIRAM0509
Copy link

Please merge this :)

@TuNguyenThanh
Copy link

@nhbravo
Copy link

nhbravo commented Dec 24, 2020

Please merge this :)

@nhbravo
Copy link

nhbravo commented Feb 17, 2021

Updates?

@liamjones
Copy link
Author

Apologies for the delay. As suggested by @vimaire, I've (finally) raised a PR for this to be added to DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#51462

If anyone interested in helping to progress the merge on DT then reviewing the PR over there would help.

@liamjones
Copy link
Author

@types/react-native-global-props has now been merged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants