Usermod BME280: Fix compilation errors for ESP32-C3 (Fixes #4362) #4363
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defer calling begin() on buses
Add support for ESP32-S3 WROOM-2 (solves Aircoookie#4099)
Fix release name macro expansion
Fix release name macro expansion
Fixed point calculation for improved accuracy, dithering in debug builds only. Averaging and optional multiplier can be set as compile flags, example for speed testing with long averaging and a 10x multiplier: -D FPS_CALC_AVG=200 -D FPS_MULTIPLIER=10 The calculation resolution is limited (9.7bit fixed point) so values larger than 200 can hit resolution limit and get stuck before reaching the final value. If WLED_DEBUG is defined, dithering is added to the returned value so sub-frame accuracy is possible in post-processingwithout enabling the multiplier.
dithering is not really needed, the FPS_MULTIPLIER is a much better option.
Avoiding name collisions with the 'delay' function.
Don't generate a response if there's no HTTP request. Fixes Aircoookie#4269
Fixes bug introduced by Aircoookie#4312.
While not used by most bus types, it's not an optional parameter.
- previous fix worked but there was still an overflow after some time passed. there were still missing roll-overs apparently: reverting these two variables back to 16bit/8bit should fix it for good.
At least for ESP32-C3 the call to the String constructor to convert numbers to String with a parameterized count of Decimals fails, because it is ambigious. --> explicitly cast the decimals parameters to `unsigned long`. Alternative would be to directly use `unsigned long` instead of `uint8_t`.
|
thanks for fixing this. |
softhack007
added
the
rebase needed
esp01_1m_full_160 failed due to slightly too large binary size, so its unrelated. |
|
Sadly I can't just update this PR, it will need manual rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4362:
At least for ESP32-C3 the call to the String constructor to convert numbers to String with a parameterized count of Decimals fails, because it is ambigious. --> explicitly cast the decimals parameters to
unsigned long.Alternative would be to directly use
unsigned longinstead ofuint8_t.