Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start StreamLintServer with localhost to misuse the gui when network is shared #3555

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brahmareddybattula
Copy link

@brahmareddybattula brahmareddybattula commented Mar 16, 2025

Added two testcases which passing.

image

Same will fail when this fix was not there.

image

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2025

CLA assistant check
All committers have signed the CLA.

@brahmareddybattula brahmareddybattula force-pushed the main branch 2 times, most recently from c41e24e to d018976 Compare March 17, 2025 02:22
@brahmareddybattula
Copy link
Author

@paul-gauthier any chance to look into this?

@paul-gauthier
Copy link
Collaborator

Thanks for your interest in aider and for taking the time to make this PR.

I'm not sure I understand the purpose of this PR and how it would be generally useful to all of aider's users?

@brahmareddybattula
Copy link
Author

brahmareddybattula commented Mar 18, 2025

Thanks for your interest in aider and for taking the time to make this PR.

I'm not sure I understand the purpose of this PR and how it would be generally useful to all of aider's users?

thanks @paul-gauthier for your time. This is start the Streamlitserver with localhost by default which we discussed here #3520.

@paul-gauthier
Copy link
Collaborator

I'm not sure what LintServer is. Most users will not be using a LintServer. So these changes would most likely break most aider installations because their lint commands will error when passed a --bind switch.

@brahmareddybattula brahmareddybattula changed the title Start LintServer with localhost to misuse the gui when network is shared Start StreamLintServer with localhost to misuse the gui when network is shared Mar 18, 2025
@brahmareddybattula brahmareddybattula changed the title Start StreamLintServer with localhost to misuse the gui when network is shared Start StreamLitServer with localhost to misuse the gui when network is shared Mar 18, 2025
@brahmareddybattula brahmareddybattula changed the title Start StreamLitServer with localhost to misuse the gui when network is shared Start StreamLintServer with localhost to misuse the gui when network is shared Mar 18, 2025
@brahmareddybattula
Copy link
Author

I'm not sure what LintServer is. Most users will not be using a LintServer. So these changes would most likely break most aider installations because their lint commands will error when passed a --bind switch.

I assume "--bind" shouldn't usable option as this should local to desktop user and if we allow which open the security risk. If you agree, we can give warn message if people try to use "--bind" option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants