-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start StreamLintServer with localhost to misuse the gui when network is shared #3555
base: main
Are you sure you want to change the base?
Conversation
c41e24e
to
d018976
Compare
d018976
to
d38e20b
Compare
@paul-gauthier any chance to look into this? |
Thanks for your interest in aider and for taking the time to make this PR. I'm not sure I understand the purpose of this PR and how it would be generally useful to all of aider's users? |
thanks @paul-gauthier for your time. This is start the Streamlitserver with localhost by default which we discussed here #3520. |
I'm not sure what LintServer is. Most users will not be using a LintServer. So these changes would most likely break most aider installations because their lint commands will error when passed a |
I assume "--bind" shouldn't usable option as this should local to desktop user and if we allow which open the security risk. If you agree, we can give warn message if people try to use "--bind" option. |
Added two testcases which passing.
Same will fail when this fix was not there.