chore(Create class for constants) #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#187 1:- create a class for device contants because we want to destroy regexes after it checked 2:- apply the condition when user check its device first time it will work but when same useragent and device check another time we return the store data which is stored when user check is first time
AhsanAyaz
force-pushed
the
issue/187-memory-leak-and-performance
branch
from
f1df8a9 to
ad9a31f
Compare
AhsanAyaz
requested changes
May 9, 2021
projects/ngx-device-detector/src/lib/device-detector.service.ts
Outdated
Show resolved
Hide resolved
projects/ngx-device-detector/src/lib/device-detector.service.ts
Outdated
Show resolved
Hide resolved
projects/ngx-device-detector/src/lib/device-detector.service.ts
Outdated
Show resolved
Hide resolved
projects/ngx-device-detector/src/lib/device-detector.service.ts
Outdated
Show resolved
Hide resolved
projects/ngx-device-detector/src/lib/device-detector.service.ts
Outdated
Show resolved
Hide resolved
projects/ngx-device-detector/src/lib/device-detector.service.ts
Outdated
Show resolved
Hide resolved
projects/ngx-device-detector/src/lib/device-detector.service.ts
Outdated
Show resolved
Hide resolved
projects/ngx-device-detector/src/lib/device-detector.service.ts
Outdated
Show resolved
Hide resolved
AhsanAyaz
approved these changes
May 11, 2021
|
Any updates on this? |
AhsanAyaz
force-pushed
the
master
branch
2 times, most recently
from
34de892 to
6423208
Compare
srnec
reviewed
Dec 21, 2021
| if (this.isTablet(userAgent)) { | ||
| return false; | ||
| } | ||
| const match = Object.keys(Constants.MOBILES_RE).find(mobile => { | ||
| return this.reTree.test(userAgent, Constants.MOBILES_RE[mobile]); | ||
| const match = Object.keys(parser.MOBILES_RE).find(mobile => { |
There was a problem hiding this comment.
what about using array.some instead of array.find?
Since you only care if there is some item matching your condition it and not looking for that item itself.
const match = Object.keys(parser.MOBILES_RE).some(mobile => this.reTree.test(userAgent, parser.MOBILES_RE[mobile]));
The same change can be applied for all occurances of this pattern in this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #187
1:- create a class for device contants because we want to destroy regexes after it checked
2:- apply the condition when user check its device first time it will work but when same useragent and device check another time we return the store data which is stored when user check is first time