Refactor: Enhance Statement.verify performance (#60)

Ahoo-Wang · Jan 7, 2023 · ba7db16 · ba7db16
1 parent 6850a25
commit ba7db16
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/cosec-api/src/main/kotlin/me/ahoo/cosec/api/policy/Statement.kt b/cosec-api/src/main/kotlin/me/ahoo/cosec/api/policy/Statement.kt
@@ -24,10 +24,10 @@ interface Statement : Named, PermissionVerifier {
     val conditions: List<ConditionMatcher>
 
     override fun verify(request: Request, securityContext: SecurityContext): VerifyResult {
-        conditions.all {
-            it.match(request, securityContext)
-        }.let { allMatched ->
-            if (!allMatched) {
+        conditions.any {
+            !it.match(request, securityContext)
+        }.let { anyNotMatched ->
+            if (anyNotMatched) {
                 return VerifyResult.IMPLICIT_DENY
             }
         }

diff --git a/cosec-gateway-server/src/main/resources/application.yaml b/cosec-gateway-server/src/main/resources/application.yaml
@@ -48,7 +48,8 @@ cosec:
   jwt:
     algorithm: hmac256
     secret: FyN0Igd80Gas8stTavArGKOYnS9uLWGA_
-
+  ip2region:
+    enabled: false
 logging:
   level:
     root: info

diff --git a/document/cosec-policy.schema.json b/document/cosec-policy.schema.json
@@ -223,7 +223,8 @@
         "actions": {
           "type": "array",
           "items": {
-            "$ref": "#/definitions/actionMatcher"
+            "$ref": "#/definitions/actionMatcher",
+            "minItems": 1
           }
         },
         "conditions": {