Avoid storing unnecessary kernel outputs #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed function names from default_output_variables to DefaultOutputVariables for consistency. Updated references in SimulationMetaDataConfiguration.jl to use the new function names.
To also improve MDBC setup as well as kernels as before
Refactored LoadSpecificCSV to use a helper function for point extraction based on dimension, improving clarity and reducing code duplication. Replaced manual loops for GravityFactor and MotionLimiter with helper functions and broadcasting for better performance and maintainability.
…h exist as a way to speed up DDT Update MovingSquare2D example by using ZeroGravityLinearDensity, which exist as a way to speed up DDT
…lities Update PreProcess.jl by removing unneeded multiple dispatch functionalities. This simplifies code because unexpected code cases are now not possible as such for the AllocateDataStructures function in shaa Allah
… of this simulation code. Update of dam break simulation in 3D to use the latest settings setup of this simulation code.
Updated to remove saving ChunkIDs
Update function inputs to match better
Work in progress to ensure cleaner code in shaa Allah
Refactored several simulation step functions to accept and operate on SimParticles and SupportParticles structs instead of passing individual arrays. This improves code clarity, reduces argument lists, and prepares the codebase for further extensibility. Also updated the time step calculation to use the SimParticles struct.
Updated zeroing and reduction functions to accept SimParticles instead of individual kernel arrays. This change simplifies function signatures and improves code clarity by grouping related arrays into a single structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KernelOutputModeTesting
julia --project=. -e 'using Pkg; Pkg.test()'https://chatgpt.com/codex/tasks/task_e_68c57462fc5883239c6c73d49c867ee0