Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(getting-started): refine docker:logs section #905

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Jan 3, 2024

  • note benign error messages
  • 10x2 log messages seems excessive; 3 pairs establishes the pattern
  • use block numbers closer to what they'll see

@dckc dckc requested a review from kbennett2000 January 3, 2024 22:19
 - 10x2 log messages seems excessive; 3 pairs establishes the pattern
 - use block numbers closer to what they'll see
@dckc dckc force-pushed the dc-benign-log-errors branch from f573bab to ff7411d Compare January 3, 2024 22:20
Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a6d733e
Status: ✅  Deploy successful!
Preview URL: https://82149cfa.documentation-7tp.pages.dev
Branch Preview URL: https://dc-benign-log-errors.documentation-7tp.pages.dev

View logs

@dckc dckc marked this pull request as ready for review January 3, 2024 22:20
Copy link
Contributor

@ivanlei ivanlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ivanlei ivanlei merged commit 6d6c4c9 into main Jan 8, 2024
4 checks passed
@ivanlei ivanlei deleted the dc-benign-log-errors branch January 8, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants