Remove curl from the prerequisites #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
a068a6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e8fdce8c.documentation-7tp.pages.dev |
| Branch Preview URL: | https://tl-remove-curl-pre.documentation-7tp.pages.dev |
toliaqat
changed the title
gibson042
reviewed
Dec 28, 2023
There was a problem hiding this comment.
I think curl is more standard for this kind of thing (e.g., note its use below for installing Docker), but really we should just defer to the nvm instructions (which cover both utilities).
|
|
||
| </details> | ||
|
|
||
|
|
||
| ### Installing NVM and Node | ||
| <details> | ||
| <summary>Installing NVM and Node on Ubuntu</summary> | ||
|
|
||
| At this point the Node Version Manager (NVM) utility will be installed. `nvm` makes it easy to select the specific version of [Node](https://nodejs.org/) that will be required for this tutorial (v18.16.0). |
There was a problem hiding this comment.
Suggested change
| At this point the Node Version Manager (NVM) utility will be installed. `nvm` makes it easy to select the specific version of [Node](https://nodejs.org/) that will be required for this tutorial (v18.16.0). | |
| At this point the [Node Version Manager](https://github.com/nvm-sh/nvm) (NVM) utility will be installed. `nvm` makes it easy to select the specific version of [Node](https://nodejs.org/) that will be required for this tutorial (v18.16.0). |
There was a problem hiding this comment.
Makes sense to me, let's go with wget!
Co-authored-by: Richard Gibson <[email protected]>
kbennett2000
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering wget is by default installed on most OSes. Let's use it and remove curl from the
Prerequisites.