chore: downgrade glob #1228
Merged
chore: downgrade glob #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mujahidkay
force-pushed
the
mk-downgrade-glob
branch
from
62d523d to
f1eef7e
Compare
Deploying documentation with
|
| Latest commit: |
45e38a4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ef7f3014.documentation-7tp.pages.dev |
| Branch Preview URL: | https://mk-downgrade-glob.documentation-7tp.pages.dev |
Muneeb147
reviewed
Oct 3, 2024
no, good catch. updating |
mujahidkay
force-pushed
the
mk-downgrade-glob
branch
from
f1eef7e to
259aac9
Compare
mujahidkay
force-pushed
the
mk-downgrade-glob
branch
from
259aac9 to
45e38a4
Compare
Muneeb147
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue arose because we introduced
globas a dependency in #1212The version introduced in this repo doesn't mesh well with the version(s) being used in some of the packages in agoric-sdk and hence, the linking step failed. Once I aligned the CI check breakage with the changes in docs repo, it was easier to pinpoint the root cause.
As a fix, I have downgraded
globto the version that works for both cases. CI check now passes on agoric-sdk with this branch: https://github.com/Agoric/agoric-sdk/actions/runs/11157393879/job/31011590384?pr=10206