Skip to content

Conversation

gibson042
Copy link
Member

Fixes #1079

Also updates to canonical spelling and capitalization for nvm and Node.js.

Copy link

cloudflare-workers-and-pages bot commented May 8, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7337f0
Status:🚫  Build failed.

View logs

Copy link
Contributor

@kbennett2000 kbennett2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question...

In this section you'll be installing prerequisite components into your environment. If you're working with your own environment rather than using a fresh Ubuntu install, you may already have some or all of these components already installed.

### Installing NVM and Node
### Installing nvm and Node.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. I asked about that in #894

Comment on lines +50 to +53
export NVM_DIR="$([ -z "${XDG_CONFIG_HOME-}" ] && printf %s "${HOME}/.nvm" || printf %s "${XDG_CONFIG_HOME}/nvm")"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is all this gobbledygook necessary? I'm pretty sure @kbennett2000 tested the source ~/.bashrc approach.

Copy link
Member Author

@gibson042 gibson042 May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That only works for bash, while Fred was using zsh. But the most important aspect of this change is including the https://github.com/nvm-sh/nvm?tab=readme-ov-file#installing-and-updating link; this block is now just an example for one-stop-shopping and could be removed entirely:

Installing nvm and Node.js on Ubuntu

At this point the nvm (Node Version Manager) utility will be installed. nvm makes it easy to select the specific version of Node.js that will be required for this tutorial (v18.16.0).

First, follow the nvm installation instructions, including sourcing nvm.sh into the shell for later steps.

Then, install Node.js.

nvm install v18.18.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block ... could be removed entirely

I think the tutorial is designed to be self-contained. Every command you have to issue is on one page. (Installing Keplr might be one exception where some steps are not covered in full.)

Fred was using zsh.

The tutorial is one path through the whole process. I think we try to distinguish requirements (node.js) from the detailed existence proof that they can be met (nvm ...).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, in which case those instructions do have a place. But I've updated to indicate that nvm is a convenient way to satisfy the Node.js requirement rather than a requirement unto itself.

@gibson042 gibson042 force-pushed the gibson-1079-installing-nvm branch from c399e4b to a7337f0 Compare May 10, 2024 14:24
@gibson042 gibson042 merged commit 7098852 into main May 10, 2024
@gibson042 gibson042 deleted the gibson-1079-installing-nvm branch May 10, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wget-based nvm installation fails on clean MacOS environment

3 participants