Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indexes for Fast USDC #46

Merged
merged 11 commits into from
Jan 9, 2025
Merged

indexes for Fast USDC #46

merged 11 commits into from
Jan 9, 2025

Conversation

turadg
Copy link
Member

@turadg turadg commented Jan 8, 2025

refs: #10598

@turadg turadg mentioned this pull request Jan 8, 2025
Merged
@turadg turadg force-pushed the ta/index-fast-usdc branch 2 times, most recently from a0271aa to 5367c4b Compare January 9, 2025 00:13
@turadg turadg marked this pull request as ready for review January 9, 2025 00:15
mergify bot added a commit to Agoric/agoric-sdk that referenced this pull request Jan 9, 2025
@mergify
chore(types): explicit ERTP type imports (#10823)
b5d1abe 
_incidental_

## Description
While working on Agoric/agoric-subql#46 I ran into type errors because some types in Fast USDC relies on ambients that weren't loaded in this usage.

This makes the imports explicit so they resolve when the package is used outside agoric-sdk.

### Security Considerations
n/a

### Scaling Considerations
n/a
### Documentation Considerations
n/a
### Testing Considerations
CI
### Upgrade Considerations
No compat concerns
@turadg turadg force-pushed the ta/index-fast-usdc branch from 5367c4b to 1305eb5 Compare January 9, 2025 16:40
@turadg turadg enabled auto-merge January 9, 2025 16:40
@turadg turadg force-pushed the ta/index-fast-usdc branch 2 times, most recently from 741fcec to 449fd0b Compare January 9, 2025 17:16
@turadg turadg force-pushed the ta/index-fast-usdc branch from 449fd0b to ea098b4 Compare January 9, 2025 17:38
@turadg turadg force-pushed the ta/index-fast-usdc branch from ea098b4 to 43b9818 Compare January 9, 2025 17:52
samsiegart
samsiegart approved these changes Jan 9, 2025
View reviewed changes
Copy link

@samsiegart samsiegart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with a3p. For pagination we can do something like:

{
  fastUsdcTransactions(before: "<previous startCursor>") {
    pageInfo {
      startCursor
      endCursor // Can use this for polling latest as well
    }
    edges {
      node {
        ...
      }
    }
  }
}

@turadg turadg merged commit ed81831 into main Jan 9, 2025
3 checks passed
@turadg turadg deleted the ta/index-fast-usdc branch January 9, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsiegart samsiegart samsiegart approved these changes

@rabi-siddique rabi-siddique Awaiting requested review from rabi-siddique

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turadg @samsiegart