lint swingset-xsnap-supervisor imports #10885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
f444785
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1b0fc54.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-lint-xsnap-supervisor.agoric-sdk.pages.dev |
turadg
added
automerge:rebase
turadg
force-pushed
the
ta/lint-xsnap-supervisor
branch
from
32cefca to
f444785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
In #10878 I noticed,
The package had disabled
import/no-extraneous-dependenciesfor some reason. That was carried forward in the recent v9 upgrade: https://github.com/Agoric/agoric-sdk/pull/10846/files#diff-9ab4ae5d071b94a2d5dd874ceb3b9a1e85913fe7ee92e4956cb9801e59777002This removes the special case and declares the deps so the rule passes.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
none