Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix advance available condition #10860

Merged
merged 1 commit into from
Jan 17, 2025
Merged

chore: fix advance available condition #10860

merged 1 commit into from
Jan 17, 2025

Conversation

0xpatrickdev
Copy link
Member

incidental

Description

Ensure test condition properly validates balance on EUD chain.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

Testing only change. This was just a bug in the test, fixing this did not surface any issues.

Upgrade Considerations

n/a

@0xpatrickdev 0xpatrickdev requested a review from a team as a code owner January 17, 2025 22:03
@0xpatrickdev 0xpatrickdev added the force:integration Force integration tests to run on PR label Jan 17, 2025
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks; I was struggling in this area

Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58c2291
Status: ✅  Deploy successful!
Preview URL: https://4c122b5b.agoric-sdk.pages.dev
Branch Preview URL: https://pc-fix-advance-check.agoric-sdk.pages.dev

View logs

@0xpatrickdev 0xpatrickdev added the automerge:rebase Automatically rebase updates, then merge label Jan 17, 2025
@mergify mergify bot merged commit 371f6f3 into master Jan 17, 2025
103 checks passed
@mergify mergify bot deleted the pc/fix-advance-check branch January 17, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants