Skip to content

Commit

Permalink
fix(integration-test): update initOptions with '--dapp-template' para…
Browse files Browse the repository at this point in the history 
…meter
  • Loading branch information
@LuqiPan
LuqiPan committed Jan 25, 2024
1 parent b3ad188 commit 2097951
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/agoric-cli/tools/getting-started.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export const gettingStartedWorkflowTest = async (t, options = {}) => {
if (process.env.AGORIC_INIT_OPTIONS) {
const opts = JSON.parse(process.env.AGORIC_INIT_OPTIONS);
initOptions.push(...opts);
initOptions['--dapp-template'] = 'dapp-fungible-faucet';

This comment has been minimized.

Sign in to view

Copy link
@mhofman

mhofman Jan 25, 2024

Member

This option should be provided first so it allows overrides. Here it forces it.

This comment has been minimized.

Sign in to view

Copy link
@LuqiPan

LuqiPan Jan 25, 2024

Author Contributor

Got it, I'm just using CI to verify my hypothesis. And it seems like initOptions is set somewhere in the registry.sh script but I haven't figured out where exactly yet.

Ref: https://github.com/Agoric/agoric-sdk/actions/runs/7660213086/job/20877026696?pr=8630#step:7:24

This comment has been minimized.

Sign in to view

Copy link
@mhofman

mhofman Jan 25, 2024

Member

Ah sorry I commented on this commit outside a PR!

Moving here: https://github.com/Agoric/agoric-sdk/pull/8630/files#r1467040656
}
t.is(
await myMain(['init', ...initOptions, 'dapp-foo']),
Expand Down

0 comments on commit 2097951

Please sign in to comment.