4.2.2 bugfix 0803 #3295
Merged
4.2.2 bugfix 0803 #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce into 4.2.2-bugfix-0803
…doc_source into 4.2.2-bugfix-0803
Cilla-luodan
commented
Aug 3, 2023
| @@ -65,7 +65,8 @@ int JoinChannel(FString token, FString channelId, int64 uid, const FChannelMedia | |||
| <parml> | |||
| <plentry id="token"> | |||
| <pt>token</pt> | |||
| <pd>在服务端生成的用于鉴权的动态密钥。详见<xref keyref="guide-token"/>。</pd> | |||
| <pd>在服务端生成的用于鉴权的动态密钥。详见<xref keyref="guide-token"/>。 | |||
| <note type="note">如果你需要同时加入多个频道或在频道间频繁切换，声网推荐你使用通配 Token 以避免每加入一个新的频道都需向服务端申请一个新的 Token，详见 <xref keyref="wildcard-token"/>。</note></pd> | |||
There was a problem hiding this comment.
“以避免”那一句话不如直接把优点说出来更直接，这样改一下是不是更好一点：
……，声网推荐你使用通配 Token 来提升加入频道或在频道间切换的速度，同时减小你的 Token 服务器的压力。详见 xxx
There was a problem hiding this comment.
我觉得这样写会有歧义，因为通配token本身并不能提升加快频道的速度，只是因为不需要每次加入一个新的频道就要重新生成token，所以省去了获取token的时间。
Cilla-luodan
commented
Aug 3, 2023
dita/RTC-NG/API/api_irtcengine_setdefaultaudioroutetospeakerphone.dita
Outdated
Show resolved
Hide resolved
Cilla-luodan
commented
Aug 3, 2023
dita/RTC-NG/API/api_irtcengine_setdefaultaudioroutetospeakerphone.dita
Outdated
Show resolved
Hide resolved
jinyuagora
reviewed
Aug 3, 2023
| @@ -4528,7 +4528,7 @@ | |||
| <keydef keys="CodecCapInfo" href="../API/class_codeccapinfo.dita"> | |||
| <topicmeta> | |||
| <keywords> | |||
| <keyword>CodecCapAgoraVideoCodecCapInfoInfo</keyword> | |||
| <keyword>AgoraVideoCodecCapInfoInfo</keyword> | |||
jinyuagora
reviewed
Aug 3, 2023
| @@ -4243,7 +4243,7 @@ | |||
| <keydef keys="CodecCapInfo" href="../API/class_codeccapinfo.dita"> | |||
| <topicmeta> | |||
| <keywords> | |||
| <keyword>CodecCapAgoraVideoCodecCapInfoInfo</keyword> | |||
| <keyword>AgoraVideoCodecCapInfoInfo</keyword> | |||
jinyuagora
reviewed
Aug 3, 2023
| @@ -4528,7 +4528,7 @@ | |||
| <keydef keys="CodecCapInfo" href="../API/class_codeccapinfo.dita"> | |||
| <topicmeta> | |||
| <keywords> | |||
| <keyword>CodecCapAgoraVideoCodecCapInfoInfo</keyword> | |||
| <keyword>AgoraVideoCodecCapInfoInfo</keyword> | |||
jinyuagora
reviewed
Aug 3, 2023
| @@ -4243,7 +4243,7 @@ | |||
| <keydef keys="CodecCapInfo" href="../API/class_codeccapinfo.dita"> | |||
| <topicmeta> | |||
| <keywords> | |||
| <keyword>CodecCapAgoraVideoCodecCapInfoInfo</keyword> | |||
| <keyword>AgoraVideoCodecCapInfoInfo</keyword> | |||
Cilla-luodan
commented
Aug 3, 2023
| @@ -1062,7 +1063,6 @@ | |||
| <li><xref keyref="AUDIO_PROCESSING_CHANNELS"/></li> | |||
| <li><xref keyref="AUDIO_PROFILE_TYPE"/></li> | |||
| <li><xref keyref="AUDIO_RECORDING_QUALITY_TYPE"/></li> | |||
| <li><xref keyref="AUDIO_REVERB_PRESET"/></li> | |||
There was a problem hiding this comment.
哈？为啥 cpp 里也删了？这个枚举类在 setLocalVoiceReverbPreset 里有用到，cpp apple unreal unity里都还在用的
There was a problem hiding this comment.
VOICE_CHANGER_PRESET 那个也是，应该是只要处理 rn、elec、flutter 即可。
There was a problem hiding this comment.
@jinyuagora 记得处理一下 flutter 的 keysmap，有没删干净的
There was a problem hiding this comment.
哈？为啥 cpp 里也删了？这个枚举类在 setLocalVoiceReverbPreset 里有用到，cpp apple unreal unity里都还在用的
setLocalVoiceReverbPreset 和 setlocalvoicechanger 已无任何平台使用
|
1 |
…doc_source into 4.2.2-bugfix-0803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.