Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.1 bugfix 0720 #3271

Merged
merged 20 commits into from
Jul 21, 2023
Merged

4.2.1 bugfix 0720 #3271

merged 20 commits into from
Jul 21, 2023

Conversation

Cilla-luodan
Copy link
Collaborator

No description provided.

@@ -43,7 +43,8 @@
<parml>
<plentry>
<pt>zones</pt>
<pd>隔声区域的设置。详见 <apiname keyref="SpatialAudioZone"/>。</pd>
<pd>隔声区域的设置。详见 <apiname keyref="SpatialAudioZone"/>。
<note type="caution" props="cpp unreal bp unity flutter electron">在 Windows 平台上,需确保 <parmname>zones</parmname> 数组中的成员个数与 <parmname>zoneCount</parmname> 的值相等,否则会导致崩溃。</note></pd>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cs?

@@ -29,7 +29,7 @@
<dd>v4.0.1</dd>
</dlentry>
</dl>
<p id="desc">SDK 默认在发送端开启小流 auto 模式(不主动发送小流),接收端主播可以调用 <xref keyref="setRemoteVideoStreamType"/> 发起小流申请,发送端收到申请后自动切换为小流模式。<ul>
<p id="desc">SDK 默认在发送端开启小流 auto 模式(不主动发送小流),主播身份的接收端可以调用 <xref keyref="setRemoteVideoStreamType"/> 发起小流申请,发送端收到申请后自动切换为小流模式。<ul>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是否需要强调下 - SDK 不响应观众角色的接收端发起的小流申请。
另外群里报的是 enum_xxx 的问题,或许 enum 那边也补充一下?
image

Copy link
Collaborator Author

@Cilla-luodan Cilla-luodan Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum 那里要不要加的问题跟提单人沟通过了,说了我们的惯例,他说 ok 的,所以就不加了。
不响应观众角色的那个我在 setRemoteVideoStreamType 里加一下,因为是说这个方法的限制。

@@ -40,9 +40,15 @@
<dd>v4.0.1</dd>
</dlentry>
</dl>
<p id="desc">SDK 默认在发送端开启小流 auto 模式,效果等同于调用该方法并将 <parmname>mode</parmname> 设置为 <apiname keyref="AUTO_SIMULCAST_STREAM"/>。如果你想修改此行为,可以调用该方法并修改 <parmname>mode</parmname> 为 <apiname keyref="DISABLE_SIMULCAST_STREAM"/>(始终不发送小流)或 <apiname keyref="ENABLE_SIMULCAST_STREAM"/>(始终发送小流)。</p>
<p conkeyref="setDualStreamMode/desc"/>
<p props="native unreal bp unity cs">该方法跟 <xref keyref="setDualStreamMode"/> 的区别在于,该方法还可以进行视频小流的配置,SDK 会根据 <parmname>streamConfig</parmname> 中的配置发送小流。</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要删一下 bp,因为 bp 没重载,不过开发分支已经删了,所以不删也行

@@ -30,7 +30,7 @@
<note type="attention">
<ul>
<li>该方法需要在加入频道后调用。</li>
<li>该方法对 <xref keyref="ChannelMediaOptions"/> 中指定发布的视频流进行截图。</li>
<li>该方法对用户订阅的远端视频流和 <xref keyref="ChannelMediaOptions"/> 中指定发布的视频流进行截图。</li>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是说,在这个方法里指定了用户 id 后,就对该用户订阅和发布的视频流都进行截图?而且感觉这个 li 中的内容跟 desc1 的合并一下就很清楚了:
该方法可以对某个指定用户发布和接收的视频流进行截图,生成一张 JPG 格式的图片,并保存至指定的路径。

有个问题:如果是对用户接收和发布的视频流进行同时截图,那截的图就会是一个把多个视频截图合并的图片么?

<codeblock props="reserve" outputclass="language-cpp"></codeblock></p>
</section>
<section id="detailed_desc">
<title>详情</title>
<p />
<note type="attention">在调用该方法前,请确保你已经调用 <xref keyref="createCustomAudioTrack" /> 方法创建自定义采集的音频轨道。</note>
<p>调用该方法设置音频在本地播放的音量后,如果你想重新调整音量,你可以再次调用该方法。</p>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句话真的不是废话嘛哈哈哈哈哈哈哈哈哈哈哈哈哈,调音量本来就是个可以重复进行的操作
看了下同类的 adjustPlayoutVolume 并没有这样的描述,俺觉得可以删。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尊重并参考前人写 adjustCustomAudioPublishVolume 时的意见,ta这样写一定是想强调什么吧,噗嗤。
image

@@ -41,7 +41,7 @@
<note type="attention">
<ul>
<li>该方法需要在调用 <xref keyref="joinChannelEx"/> 后调用。</li>
<li>该方法对 <xref keyref="ChannelMediaOptions"/> 中指定发布的视频流进行截图。</li>
<li>该方法对用户订阅的远端视频流和 <xref keyref="ChannelMediaOptions"/> 中指定发布的视频流进行截图。</li>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

takeSnapshot 那里改了的话,这句就可以删了

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为这里做了 conkeyref 到 takeSnapshot/desc1,不删就重复了

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note 没有包含在 desc1 里

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note 没有包含在 desc1 里

是的,note 本来就是单独写的,我说“这句就可以删了”是指这条 li,不是整个 note 哈

@@ -39,6 +39,7 @@
<ul><li>雷声</li>
<li>爆炸声</li>
<li>破裂声等</li></ul></p>
<note props="cpp android flutter unity bp unreal cs rn">目前暂不推荐在 Android 6.0 及以下版本的设备上开启该功能。</note>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

得去掉讨厌的 cs

@Cilla-luodan Cilla-luodan merged commit 46ae7aa into master Jul 21, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants