Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Filter books by genres/title #16

Open
wants to merge 5 commits into
base: feature/browse-books
Choose a base branch
from
Open

Feature/Filter books by genres/title #16

wants to merge 5 commits into from

Conversation

beniaminmuresan
Copy link
Contributor

@beniaminmuresan beniaminmuresan commented May 26, 2020 •
edited
Loading

This PR does the following:

  • Add scope on model that filters by genre (array of ids) and by title (string)
  • Add support to query by genre and title for book index action
  • Create book_genres table { book_id, genre_id }
  • Create genres table with attributes { name }

Note: This PR is depends on the other opened PR - Feature/Browse Books, please review that first, so I can change the base branch.

@beniaminmuresan beniaminmuresan changed the title Feature/Filter books by genres Feature/Filter books by genres/title May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandru-calinoiu alexandru-calinoiu Awaiting requested review from alexandru-calinoiu

@pirvudoru pirvudoru Awaiting requested review from pirvudoru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beniaminmuresan