forked from thesuss/shf-project
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIKE] s3 lifecycle rules for backups #906
Open
BasilMawejje
wants to merge
13
commits into
AgileVentures:develop
Choose a base branch
from
BasilMawejje:spike/backup-s3-lifecycle-rules
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[SPIKE] s3 lifecycle rules for backups #906
BasilMawejje
wants to merge
13
commits into
AgileVentures:develop
from
BasilMawejje:spike/backup-s3-lifecycle-rules
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 24, 2021
16f12dd
to
b542219
Compare
6226a43
to
016ec4e
Compare
Modify method signature comment to reflect storage_rules as a list
houndci-bot
reviewed
Aug 31, 2021
5fe838c
to
3101aed
Compare
96fb4b3
to
631f7e0
Compare
dcd8f44
to
2cd76e3
Compare
2cd76e3
to
5dfe439
Compare
…into spike/backup-s3-lifecycle-rules
I put up a wiki page that has the backups schedules: https://github.com/AgileVentures/shf-project/wiki/Backups-on-AWS Other Misc. thoughts:
|
202c0fa
to
12025ca
Compare
12025ca
to
d4e3fee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT Story:
PT URL: https://www.pivotaltracker.com/story/show/173667123
Changes proposed in this pull request:
Screenshots (Optional):
N/A
Ready for review:
@
Ps:
.env
file to setup the test database.