Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: side-to-side comparison in the playground #980

Merged
merged 13 commits into from
Dec 1, 2023
Merged

[FEATURE]: side-to-side comparison in the playground #980

merged 13 commits into from
Dec 1, 2023

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Dec 1, 2023

Description

  • Added a new side-to-side comparison functionality in the playground.
  • Implemented a user-friendly interface to toggle between side-to-side view and tab view.

MohammedMaaz
MohammedMaaz approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@MohammedMaaz MohammedMaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmabrouk
Copy link
Member

mmabrouk commented Dec 1, 2023

@MohammedMaaz @bekossy
I think the last commit removed some of the features (draggability), can you please check

mmabrouk
mmabrouk approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bekossy and @MohammedMaaz!

@mmabrouk mmabrouk merged commit 51b7e65 into main Dec 1, 2023
7 of 8 checks passed
@mmabrouk mmabrouk deleted the feat/-side-to-side-comparison-in-the-playground branch December 1, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

@MohammedMaaz MohammedMaaz MohammedMaaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekossy @mmabrouk @MohammedMaaz