Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Make use of fix local uri for deployments #2072

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Enhancement]: Make use of fix local uri for deployments #2072

wants to merge 4 commits into from

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Sep 10, 2024 •
edited
Loading

Description

This PR utilizes the DNS entry created by Docker when creating an app from the CLI & UI template in Agenta while running evaluations.

For more context, see this link.

Changes

  • Check deployment.uri during evaluations to see if it contains localhost, and, if so, use the DNS entry for the LLM application running on Docker.
  • Update the evaluations task to pass the deployment object instead of the URI, allowing the use of the container_id in the deployment object.

What to QA

  • Run automatic evaluations (from a Windows, Linux & Mac laptops).
  • View the evaluation results.
  • Compare evaluation results.

Acceptance Tests

  • Ensure that evaluations run successfully without any errors.

@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 3:16pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 3:16pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 10, 2024
@dosubot dosubot bot added Backend enhancement New feature or request labels Sep 10, 2024
@aybruhm aybruhm mentioned this pull request Sep 10, 2024
Closed
jp-agenta
jp-agenta approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@jp-agenta jp-agenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aakrem -- As part of the Application Structure project we might want to rethink networking.
@aybruhm -- Thanks for taking care of this.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
mmabrouk
mmabrouk reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am not sure what is the context. Is there issues with the docker internal solution?

@aybruhm
Copy link
Member Author

aybruhm commented Sep 11, 2024

Looks good to me. I am not sure what is the context. Is there issues with the docker internal solution?

Contexts:

@mmabrouk
Copy link
Member

Thanks @aybruhm lgtm. I'll let you organize QA & all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

@jp-agenta jp-agenta jp-agenta approved these changes

Assignees
No one assigned
Labels
Backend enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aybruhm @mmabrouk @jp-agenta @LucasTrg