-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Projects - Checkpoint 2 #2065
base: feature/age-662-project-1-add-update-tables-columns
Are you sure you want to change the base?
[feature] Projects - Checkpoint 2 #2065
Conversation
…s and evaluations models to be project-specific
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ng relationship mapper in models
… applications, & evaluators
…n-database_routers
…e down_revision head
…reate Alembic migration for project_id scoping
…exists in a table
… alembic migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aybruhm -- I have a few comments, things I want to discuss with you before I can approve, but... man, this PR is amazing ! Great job, for real !
…e_project_id_from_request
- set project_id from request (if it exists) to request.state - otherwise, set the default project id to request.state - improve try-except-finally to set default user_id
…d from request.state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @aybruhm ! lgtm.
Description
This PR introduces backward compatibility enhancements to:
Related Issues
Closes:
Sibling PRs
Changes
Project-Specific Scoping
project_id
to database entities including testsets, applications, evaluators, evaluations models and beyond.Database and Migration Adjustments
project_id
in DB entities, add default project to scoped DB entities, update evaluators with app names, etc.Utility Functions and Middleware
project_id
from request ; path parameters, query parameters or request body.project_id
to request state.Other Changes
project_id
fromrequest.state
.AppDB
andEvaluatorConfigDB
to deprecated models file.What to QA
Acceptance Tests
Ensure that the above items work without triggering any 500 errors from the backend.