-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Observability - Checkpoint 1 #2055
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ce, only returns trace_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fixes @jp-agenta
Overall lgtm. I've added a couple of comments here and there, please check them out. There is also the point about load dot env (but totally not a blocker).
@aybruhm I think we're ready to QA.
@jp-agenta Could you please do a quick update to the docs (no need to overinvest, just make sure we don't have wrong information there, I will take over the rewrite soon)
@jp-agenta @aybruhm can you please update any examples / docs that uses the old version, so that we don't have any example or code that does not work out.
I guess this also means deprecation of things, right? This would require some proper notice I guess (although we're explicitly in beta). @jp-agenta can you give it a thought.
Description
Changes
Relates Issues
AGE-736
Replace in standard tracing in with OTel tracing in SDKAGE-737
Add custom inline trace exporter (OTel -> inline traces) in SDKAGE-738
Add custom trace processor (spans -> trace) in SDKAGE-739
Add custom trace receiver (route) to observability API and serviceAGE-740
Add custom trace adapter (new -> old) to observability serviceAGE-741
Add example with existing OTel instrumentation libraryQA
Regression
oss
cloud
,inline trace
includes spans as before, and Observability includes spans as beforeFeatures
oss
cloud
,inline trace
includes spans from instrumentation library, and Observability includes spans from instrumentation library