Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Observability - Checkpoint 1 #2055

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

jp-agenta
Copy link
Contributor

@jp-agenta jp-agenta commented Sep 3, 2024

Description

  • Replaces custom tracing capture, processors, and exporters with standard Open Telemetry SDK.
  • Replaces custom tracing receiver with standard OTLP receiver.
  • Add app example with instrumentation library.

Changes

  • WIP

Relates Issues

  • AGE-736 Replace in standard tracing in with OTel tracing in SDK
  • AGE-737 Add custom inline trace exporter (OTel -> inline traces) in SDK
  • AGE-738 Add custom trace processor (spans -> trace) in SDK
  • AGE-739 Add custom trace receiver (route) to observability API and service
  • AGE-740 Add custom trace adapter (new -> old) to observability service
  • AGE-741 Add example with existing OTel instrumentation library

QA

Regression

  • Test existing examples (litellm, rag, etc)
    • Applications run without issues in oss
    • Applications run without issues in cloud, inline trace includes spans as before, and Observability includes spans as before

Features

  • Test example with OTel instrumentation library
    • Application runs without issues in oss
    • Application runs without issues in cloud, inline trace includes spans from instrumentation library, and Observability includes spans from instrumentation library

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 3:02pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 3:02pm

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fixes @jp-agenta
Overall lgtm. I've added a couple of comments here and there, please check them out. There is also the point about load dot env (but totally not a blocker).

@aybruhm I think we're ready to QA.
@jp-agenta Could you please do a quick update to the docs (no need to overinvest, just make sure we don't have wrong information there, I will take over the rewrite soon)
@jp-agenta @aybruhm can you please update any examples / docs that uses the old version, so that we don't have any example or code that does not work out.

I guess this also means deprecation of things, right? This would require some proper notice I guess (although we're explicitly in beta). @jp-agenta can you give it a thought.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI example lgtm This PR has been approved by a maintainer SDK size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants