Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Added logic for tracking application last modified by #2023

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Aug 26, 2024

Description

This PR introduces a minimal app tracking functionality by introducing fields to capture both the updated_at timestamp and the user responsible for modifications (modified_by). These changes span both the frontend and backend, ensuring accurate tracking of application updates.

Related Issue

Closes AGE-541

Changes

  • Frontend:

    • Updated the ListAppItem interface and AppCard component to include the updated_at field.
  • Backend:

    • Added a modified_by_id column to the AppDB model for tracking the last user who modified an application.
    • Enhanced the app API converter model to include the updated_at field.
    • Implemented a new function in app_manager to update the last_modified_by attribute whenever an application is modified.
    • Added functionality in the routers to track the last_modified_by user.

What to QA

  • New Variant:
    • Test creating and deleting a new variant.
  • Variant Deployment:
    • Deploy a new variant and verify that it works as expected.
  • Variant Updates:
    • Update a variant and confirm the changes are reflected correctly.
  • Evaluator Management:
    • Create, delete, and update evaluators and ensure they behave as intended.
  • Evaluation Runs:
    • Run both automatic and human evaluations, validating that they complete without issues.
  • Human Evaluation Management:
    • Test creating, updating, and deleting human evaluations.
  • Auto Evaluation Management:
    • Test creating and deleting auto evaluations.

Acceptance Tests

  • Ensure that the routers responsible for variant creation/deletion, deployment, evaluator management, and evaluations work correctly.
  • Verify that all relevant endpoints behave as expected when performing the above actions.

Note (New Schema Changes): The Alembic migration script needs to be applied using the following command:

docker exec -w /app/agenta_backend/migrations/postgres agenta-backend-1 alembic -c alembic.oss.ini upgrade head

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 0:48am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 0:48am

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 27, 2024
@aybruhm
Copy link
Member Author

aybruhm commented Aug 29, 2024

@aybruhm aybruhm merged commit e7cd1ff into main Aug 29, 2024
13 checks passed
@aybruhm aybruhm deleted the feature/age-541-endpoint-for-app-last-modified branch August 29, 2024 08:26
@zenUnicorn
Copy link
Contributor

All tests run successfully without issues ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend feature Frontend lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants