[Enhancement]: Add 'app_type' column for AppDB model with updated API responses #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe' to AppDB model
…pe enum with RAG, and update App API response
- Create DB function to get 'app_type' from template - Update DB function 'create_app_and_envs' to include 'app_type'
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
…_app_type_from_template_by_id'
…s for app categorization
…atest migration head - Refactored the migration check to compare the current database migration head against the latest migration script head. - Enhanced `get_current_migration_head_from_db` to ensure only one migration head is tracked. - Updated logic in `get_pending_migration_head` to reduce unnecessary checks and handle first-time setup more efficiently. - Improved error handling and clarified logging messages for better debugging.
Failing CLI Command Tests / Serve-to-OSS:The failing test is due to a missing schema migration in OSS production.
CLI Commands Working Locally:
Next Steps:
|
mmabrouk
approved these changes
Aug 30, 2024
...ackend/migrations/postgres/versions/1abfef8ed0ef_added_the_app_type_column_to_the_app_db_.py
Outdated
Show resolved
Hide resolved
…lumn to the app_db table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
app_typecolumn in theAppDBmodel and updates the corresponding API responses. The changes include defining anAppTypeenum, specifying the enum type for theapp_typecolumn, and updating the backend to properly handle and return the new app type in API responses. Additionally, a schema migration script has been generated and applied using Alembic.Related Issue
Closes AGE-540
Sibling PRs
Changes Included:
AppTypeenum and extended support for other app types.AppDBmodel to include theapp_typecolumn.create_app_and_envsandapp_type_from_templatefunctions to support the new enum.app_typecolumn.What to QA
app_type.app_typeis correctly reflected (should be set to 'custom').app_typecolumn has been added with the correct enum type.Acceptance Tests
app_typeis correctly reflected in the playground.app_typeis correctly set to 'custom' and the app works as expected.app_typecolumn is added to theapp_dbtable and mapped correctly with the enum type.