Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: delete created app variant #1977

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Test: delete created app variant #1977

wants to merge 3 commits into from

Conversation

ashrafchowdury
Copy link
Collaborator

Description:
After the AB testing was finished, wrote a test to delete the created app variant.

Test added:

  • Delete created app variant
  • Delete created evaluation for ab-test
  • Check there is only one variant present on the app

@vercel Vercel
Copy link

vercel bot commented Aug 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 10:53am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 10:53am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. cypress reactjs tests labels Aug 10, 2024
@aakrem aakrem requested a review from bekossy August 12, 2024 08:43
bekossy
bekossy approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ashrafchowdury

@mmabrouk @aakrem LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2024
aakrem
aakrem requested changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change

agenta-web/cypress/e2e/ab-testing-evaluation.cy.ts Outdated Show resolved Hide resolved
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Aug 14, 2024
@bekossy bekossy self-requested a review September 6, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bekossy bekossy Awaiting requested review from bekossy

@aakrem aakrem Awaiting requested review from aakrem

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cypress reactjs size:M This PR changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashrafchowdury @aakrem @bekossy