Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: TestsetTable component code has been refactored #1770

Conversation

ashrafchowdury
Copy link
Contributor

Description
The TestsetTable component's code has been refactored to enhance code navigation and readability.

Major refactors:

  • Sub-components have been separated from the TestsetTable component.
  • Organized the code according to a standard format.
  • Renamed the 'loading' useState to prevent confusion with the 'isLoading' hook.
  • Enhanced the logic of the function.
  • Introduced a new function called createNewColDefs to avoid code repetition.

Possible enhancements:

Issue
Closes #1764

…ability

- separated sub-components into new components
- renamed the loading state hook
- aligned all the codes
- improved function logic
- created a new function named createNewColDefs to avoid code duplication
Copy link

vercel bot commented Jun 7, 2024

@ashrafchowdury is attempting to deploy a commit to the mmabrouk's projects Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Frontend refactoring labels Jun 7, 2024
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 0:23am

Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ashrafchowdury!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 10, 2024
@ashrafchowdury ashrafchowdury closed this by deleting the head repository Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend lgtm This PR has been approved by a maintainer refactoring size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactore: TestsetTable.tsx component code for better readability
2 participants