Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db-postgres): add support of Alembic #1768

Open
wants to merge 23 commits into
base: postgres
Choose a base branch
from
Open

feat(db-postgres): add support of Alembic #1768

wants to merge 23 commits into from

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Jun 6, 2024 •
edited
Loading

Description

This PR introduces Alembic for managing database migrations. See readme on how to get started.

@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 0:32am

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 6, 2024
@aybruhm aybruhm requested review from aakrem and mmabrouk June 6, 2024 11:29
@aakrem
Copy link
Collaborator

aakrem commented Jun 6, 2024

@aybruhm thanks for the PR.
This is to migrate from sql schema to another sql schema as far as I have seen.
If yes do we need this now ?

@aybruhm
Copy link
Member Author

aybruhm commented Jun 6, 2024 •
edited
Loading

@aybruhm thanks for the PR. This is to migrate from sql schema to another sql schema as far as I have seen. If yes do we need this now ?

Yes, we do. My approach is no different than the one shown here:

image

However, my method is recommended because the one shown above won't detect or keep track of the changes made.

Edit: Another thing to note also is that the approach shown in the image is only recommendable when you are working on a hobby project.

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jun 7, 2024
@aybruhm aybruhm requested a review from aakrem June 7, 2024 11:46
@aybruhm aybruhm marked this pull request as draft June 8, 2024 05:45
@aakrem aakrem added the db label Jun 14, 2024
@aakrem aakrem changed the title [Feat]: Alembic migrations feat(db-postgres): add support of Alembic Jun 15, 2024
@aybruhm aybruhm marked this pull request as ready for review June 28, 2024 12:41
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk Awaiting requested review from mmabrouk

@aakrem aakrem Awaiting requested review from aakrem

Assignees
No one assigned
Labels
Backend db enhancement New feature or request feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aybruhm @aakrem