Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix litellm integration #1726

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix litellm integration #1726

merged 2 commits into from
May 31, 2024

Conversation

mmabrouk
Copy link
Member

  1. Removed the requirement for litellm. Otherwise we would need to require all the libraries we would integrate with. Now we do the imports dynamically
  2. Fixed a bug in the integration. The integration did not work for me at all. Not sure how it worked for you @aybrum. The object that we were logging was wrong.

I will write the rest of the points of my review in the original PR

@mmabrouk
- Removed requirement llm
02ed5da 
- Fixed bug in logging
@vercel Vercel
Copy link

vercel bot commented May 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 2:33pm

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 31, 2024
aybruhm
aybruhm requested changes May 31, 2024
View reviewed changes
Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, @mmabrouk. I added some comments.

@mmabrouk mmabrouk requested a review from aybruhm May 31, 2024 14:32
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 31, 2024
@aybruhm aybruhm merged commit b52d859 into 1582-age-159-add-integration-with-litellm-for-observability May 31, 2024
6 checks passed
@aybruhm aybruhm deleted the fix-llm-integration branch May 31, 2024 14:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aybruhm aybruhm aybruhm approved these changes

Assignees
No one assigned
Labels
CLI example lgtm This PR has been approved by a maintainer SDK size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmabrouk @aybruhm